Debug Undefined Feature to echo back Uknown tokens. #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmith-hs
requested changes
Jan 19, 2024
Comment on lines
46
to
53
| final FeatureActivationStrategy feat = interpreter | ||
| .getConfig() | ||
| .getFeatures() | ||
| .getActivationStrategy(ECHO_UNDEFINED); | ||
|
|
||
| if (result.isEmpty() && feat.isActive(interpreter.getContext())){ | ||
| result = master.getImage(); | ||
| } |
There was a problem hiding this comment.
If the expression renders an empty string, {{ '' }} then we should allow an empty string to be output.
If instead we moved this to line 24:
if (var == null && feat.isActive(interpreter.getContext()) {
return new RenderedOutputNode(master.getImage());
}We can make sure that we're only echoing back when it's undefined.
Also, make sure that you run mvn prettier:write to format the code, as we have tab spacing set to 2 for this project.
|
thank you both @jasmith-hs & @abarrafo for helping with this and merging |
|
Hey @jasmith-hs , just curious on what your release lifecycle is? Any idea on when the next release will make is into maven central? Thanks so much |
|
@abarrafo I put it on my todo list. I'm going out of town so I'll either be able to release it tomorrow or in about a week and a half |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this PR - Render back unresolved tokens. Implemented instead with features as suggested by @jasmith-hs and named
ECHO_UNDEFINED. I originally wanted to call it DEBUG_UNDEFINED to get close to this feature in jinja2, but that offers a bit more.