Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make restricted methods and properties to be configurable in JinjavaConfig #1076

Merged
merged 6 commits into from
May 25, 2023

Conversation

manheychiu
Copy link
Contributor

In JinjavaBeanELResolver, restrict methods and properties based on the values from JinjavaConfig (restrictedMethods, restrictedProperties and deferredExecutionRestrictedMethods.

@manheychiu manheychiu force-pushed the restricted-methods-in-config branch from 2c318fe to 012183b Compare May 24, 2023 21:11
Copy link
Contributor

@jasmith-hs jasmith-hs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the last point about immutability is addressed

src/main/java/com/hubspot/jinjava/JinjavaConfig.java Outdated Show resolved Hide resolved
src/main/java/com/hubspot/jinjava/JinjavaConfig.java Outdated Show resolved Hide resolved
src/main/java/com/hubspot/jinjava/JinjavaConfig.java Outdated Show resolved Hide resolved
@manheychiu manheychiu requested a review from hs-lsong May 24, 2023 23:09
@manheychiu manheychiu merged commit bb95c0c into master May 25, 2023
@manheychiu manheychiu deleted the restricted-methods-in-config branch May 25, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants