-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make restricted methods and properties to be configurable in JinjavaConfig
#1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmith-hs
reviewed
May 24, 2023
src/main/java/com/hubspot/jinjava/el/ext/JinjavaBeanELResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/hubspot/jinjava/el/ext/JinjavaBeanELResolver.java
Outdated
Show resolved
Hide resolved
manheychiu
force-pushed
the
restricted-methods-in-config
branch
from
May 24, 2023 21:11
2c318fe
to
012183b
Compare
jasmith-hs
approved these changes
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the last point about immutability is addressed
hs-lsong
reviewed
May 24, 2023
src/main/java/com/hubspot/jinjava/el/ext/JinjavaBeanELResolver.java
Outdated
Show resolved
Hide resolved
hs-lsong
reviewed
May 24, 2023
src/main/java/com/hubspot/jinjava/el/ext/JinjavaBeanELResolver.java
Outdated
Show resolved
Hide resolved
hs-lsong
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
JinjavaBeanELResolver
, restrict methods and properties based on the values fromJinjavaConfig
(restrictedMethods
,restrictedProperties
anddeferredExecutionRestrictedMethods
.