Add feature flag to stop defaulting null datetime filter args to current time #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boulter
changed the title
jasmith-hs
changed the base branch from
master
to
jboulter-add-features-flags-to-jinjava-config
jasmith-hs
reviewed
May 3, 2023
| .getActivationStrategy(FIXED_DATE_TIME_FILTER_NULL_ARG); | ||
|
|
||
| if (feat.isActive()) { | ||
| var = ((DateTimeFeatureActivationStrategy) feat).getActivateAt(); |
There was a problem hiding this comment.
These are not safe casts
There was a problem hiding this comment.
In general, true, but for this particular feature it will be.
There was a problem hiding this comment.
If the feature-flag is changed to FeatureStrategies.ACTIVE, this will blow up at runtime
There was a problem hiding this comment.
Yes. But for compatibility reasons, this has to return a valid date. So it's either a casting exception or some other exception.
Base automatically changed from
jboulter-add-features-flags-to-jinjava-config
to
master
May 3, 2023 13:22
boulter
commented
May 3, 2023
| @@ -41,7 +42,7 @@ public void testSafeStringCanBeEscaped() { | |||
| .isInstanceOf(SafeString.class); | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore | |||
There was a problem hiding this comment.
sometimes this is not faster when building.
boulter
changed the title
boulter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is like #1065, but uses the new feature flags instead of adding to JInjavaConfig.
#1066 should be merged first.