Add allow_snake_case filter and legacy override to serialize with snake_case
#1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at also accepts snake_case keys
…'t directly for output
…if legacy override is set
boulter
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a filter that allows a map using camelCase attributes to be accessible using snake_case. In jinjava, we allow bean properties to be accessed using snake_case, despite the java methods using camelCase to define them. If we serialize using a default BeanSerializer, then the keys will be in camelCase and running a second pass due to using eager execution will not work as we'd be trying to access a map with camelCase keys using snake_case properties.
I also added a simple legacy override
useSnakeCasePropertyNamingwhich makes jackson serialize withsnake_caseproperties by default. But we can't use that at HubSpot as we need to support legacy behaviour.