Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore dist directory #237

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: Ignore dist directory #237

wants to merge 1 commit into from

Conversation

joe-yeager
Copy link
Contributor

Description and Context

Ignore dist directory

@brandenrodgers
Copy link
Contributor

This might not be a safe change. Some devs (especially CMS devs) leverage a build step before upload. Our own Webpack CMS CLI plugin is an example. But in general it's pretty common for the output of that to go into dist, which means this change could have some unexpected outcomes for users.

That being said, I do agree that we should be ignoring the build output directory that we use during our own local dev flows. What if we customize the output directory for Vite during local dev and then ignore that directory instead? That way there's no chance of this disrupting any existing workflows.

@joe-yeager
Copy link
Contributor Author

joe-yeager commented Feb 6, 2025

This might not be a safe change. Some devs (especially CMS devs) leverage a build step before upload. Our own Webpack CMS CLI plugin is an example. But in general it's pretty common for the output of that to go into dist, which means this change could have some unexpected outcomes for users.

That being said, I do agree that we should be ignoring the build output directory that we use during our own local dev flows. What if we customize the output directory for Vite during local dev and then ignore that directory instead? That way there's no chance of this disrupting any existing workflows.

@brandenrodgers - That all sounds good, I opened this more or less to start the discussion. We discussed hs-dist in the thread. Thoughts on that?

@joe-yeager joe-yeager marked this pull request as draft February 10, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants