chore!: Rename Mode to CmsPublishMode #1269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
changed the title
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
camden11
changed the title
kemmerle
reviewed
Nov 25, 2024
lib/validation.ts
Outdated
| ).join(', ')}.`; | ||
| if (cmsPublishMode != null) { | ||
| logger.error( | ||
| [`The CMS publish mode "${mode}" is invalid.`, modesMessage].join(' ') |
There was a problem hiding this comment.
I think mode needs to be changed to cmsPublishMode here.
kemmerle
reviewed
Nov 25, 2024
| @@ -5,7 +5,7 @@ | |||
| "license": "Apache-2.0", | |||
| "repository": "https://github.com/HubSpot/hubspot-cli", | |||
| "dependencies": { | |||
| "@hubspot/local-dev-lib": "2.3.0", | |||
| "@hubspot/local-dev-lib": "0.1.0-experimental.0", | |||
There was a problem hiding this comment.
Remember to change this back
joe-yeager
reviewed
Nov 25, 2024
commands/config/set.ts
Outdated
| @@ -73,7 +76,7 @@ exports.handler = async options => { | |||
| exports.builder = yargs => { | |||
| yargs | |||
| .options({ | |||
| defaultMode: { | |||
| defaultCmsPublishMode: { | |||
|
Tested out the changes with both the new and deprecated config, updating both defaultMode and defaultCmsPublishMode. It all appears to be WAD to me, unless there are other test scenarios I'm missing. Will give a final ✅ when merge conflicts and feedback are addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
See issue: https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/718
and LDL PR: HubSpot/hubspot-local-dev-lib#216
This updates the CLI to handle LDL's renamed exports related to
CmsPublishMode. It also changes all references tomodein the CLI tocmsPublishMode, including the--modeflag that can be passed to commands.TODO
Who to Notify
@brandenrodgers @kemmerle @joe-yeager