[Draft] Improving slow query log payload #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmdmattingly
commented
Dec 22, 2022
Comment on lines
70
to
+76
| public SlowLogQueueService(Configuration conf) { | ||
| this.isOnlineLogProviderEnabled = conf.getBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY, | ||
| HConstants.DEFAULT_ONLINE_LOG_PROVIDER_ENABLED); | ||
| this.slowLogOperationJsonMaxCols = conf.getInt(HConstants.SLOW_LOG_OPERATION_JSON_MAX_COLS, | ||
| HConstants.SLOW_LOG_OPERATION_JSON_MAX_COLS_DEFAULT); | ||
| this.slowLogOperationJsonEnabled = conf.getBoolean(HConstants.SLOW_LOG_OPERATION_JSON_ENABLED, | ||
| HConstants.SLOW_LOG_OPERATION_JSON_ENABLED_DEFAULT); |
There was a problem hiding this comment.
We could consider registering this class with the ConfigurationManager and implementing ConfigurationObserver to make these dynamic, but I omitted that complication from this initial draft. I'm open to input on whether that should make it into our first upstream iteration.
Comment on lines
+2170
to
+2174
| try { | ||
| return operation.call().toJSON(maxCols); | ||
| } catch (Exception e) { | ||
| LOG.warn("Exception when deriving operation JSON", e); | ||
| } |
There was a problem hiding this comment.
We introduce the possibility for IOEx on each ProtobufUtil#toX call and on Operation#toJSON. I made this toJson method to unify the suppression of these IOExceptions, but I'd understand if there's pushback on this approach
|
Closing in favor of an upstream PR: apache#4937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-27536
I've loaded the server changes onto a test host and verified the following two states:
hbase.regionserver.slowlog.operation.json.enabled== false results in an empty string foroperationJsonhbase.regionserver.slowlog.operation.json.enabled== true results in anoperationJsonas expected.Here's a picture of the entire
OnlineLogEntryfor aMutateexample:And here's a copy of the
operationJsonfor aScanexample: