SaslPropertiesResolver should not allow mutation of its internal state (

#32) * SaslPropertiesResolver should not allow mutation of its internal state * Keep SASL properties map sorted --------- Co-authored-by: Charles Connell <[email protected]>
HubSpot · Nov 7, 2023 · 6761522 · 6761522
1 parent 547beb8
commit 6761522
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/...roject/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPropertiesResolver.java b/...roject/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPropertiesResolver.java
@@ -19,6 +19,7 @@
 
 import java.net.InetAddress;
 import java.util.Map;
+import java.util.SortedMap;
 import java.util.TreeMap;
 
 import javax.security.sasl.Sasl;
@@ -38,7 +39,7 @@
  *
  */
 public class SaslPropertiesResolver implements Configurable{
-  private Map<String,String> properties;
+  private SortedMap<String,String> properties;
   Configuration conf;
 
   /**
@@ -82,7 +83,7 @@ public Configuration getConf() {
    * @return sasl Properties
    */
   public Map<String,String> getDefaultProperties() {
-    return properties;
+    return new TreeMap<>(properties);
   }
 
   /**
@@ -91,7 +92,7 @@ public Map<String,String> getDefaultProperties() {
    * @return the sasl properties to be used for the connection.
    */
   public Map<String, String> getServerProperties(InetAddress clientAddress){
-    return properties;
+    return new TreeMap<>(properties);
   }
 
   /**
@@ -111,7 +112,7 @@ public Map<String, String> getServerProperties(InetAddress clientAddress,
    * @return the sasl properties to be used for the connection.
    */
   public Map<String, String> getClientProperties(InetAddress serverAddress){
-    return properties;
+    return new TreeMap<>(properties);
   }
 
   /**