Add endpoint to look up services by host and port #290
Conversation
| throw Throwables.propagate(e); | ||
| } | ||
| return Optional.absent(); | ||
| } |
There was a problem hiding this comment.
This seems horribly inefficient, but can't think of anything better since zk is backing it. Unless there's another place this data is stored I don't know about?
There was a problem hiding this comment.
Check out how the state resource is grabbing this data. There should be a precompiled Collection (which includes the upstreams) in memory already
| for (BaragonServiceState state : services) { | ||
| for (UpstreamInfo upstreamInfo : state.getUpstreams()) { | ||
| if (upstreamInfo.getUpstream().matches(String.format("%s\\.\\w+:%s", host, port))) { | ||
| return state; |
There was a problem hiding this comment.
It's possible that there is more than one, we should probably return a List/Collection
| Collection<BaragonServiceState> services = objectMapper.readValue(stateCache.getState().getUncompressed(), new TypeReference<Collection<BaragonServiceState>>(){}); | ||
| for (BaragonServiceState state : services) { | ||
| for (UpstreamInfo upstreamInfo : state.getUpstreams()) { | ||
| if (upstreamInfo.getUpstream().matches(String.format("%s\\.\\w+:%s", host, port))) { |
There was a problem hiding this comment.
why the regex here instead of a straight .equals?
There was a problem hiding this comment.
I'm assuming people will send in params like adjective-noun and 1234, but the upstreams are in the format adjective-noun.env.network.net:1234, so equals won't work. We can change the input type, or make this regex much more specific. Either is good with me.
There was a problem hiding this comment.
We can expect the full dns name:port, the short hostnames is only an internal shortcut
No description provided.