Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the hosts provider and support ssl in client #245

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Conversation

ssalinas
Copy link
Member

  • allows the user to more easily set a Provider<List<String>> for hosts in the BaragonClientProvider (this was possible in the constructor before, but not the provider). Does the same for auth key
  • hosts are now http(s)://host:port instead of just host:port so that we can easily support ssl. Values will be prepended with http:// if only the hostname is passed in (not checked for the provider, only for the static list of hosts)
  • A 404 for a collection now throws a BaragonClientException with a status code of 404 instead of returning an empty list

@jhaber

@ssalinas
Copy link
Member Author

Further tweaks, updated this so the client can just take in full base urls instead of having to always specify contextPath separately

@ssalinas ssalinas merged commit 6c700e4 into master Feb 15, 2018
@ssalinas ssalinas deleted the client branch February 15, 2018 14:20
@ssalinas ssalinas added this to the 0.6.0 milestone Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant