Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish UI portion of ServiceDetail page #214

Merged
merged 5 commits into from
Feb 17, 2017
Merged

Commits on Feb 13, 2017

  1. Finish UI portion of ServiceDetail page

    Finish off (most of) the visual portion of the ServiceDetail page.  I
    still need to attach the interactions, including the modals, and I would
    like to tool around some more with the request history panel. The
    existing pane is filterable and can be paged through, and I would like
    to at least get filterable done. Unfortunately, that is probably going
    to involve making my own component rather than reusing the `UITable`
    component.
    PtrTeixeira committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    717bc2f View commit details
    Browse the repository at this point in the history
  2. Attach modals to service detail page

    Attach the modals to remove upstreams, reload configs, and delete the
    modal to the service detail page. Still to be done is paginating and
    filtering the request history in the 'Recent Requests' panel.
    PtrTeixeira committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    c3da152 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2017

  1. Attach pagination/search to requests panel

    Limit the number of results displayed at a time to 5, and add buttons so
    that the user can page through the results. Also add a quick search box
    to the table. Neither the paging not the search are nearly as nice as on
    the existing system; in particular, the table doesn't have the "Showing
    {} from {} (filtered from {})" text on the original, and the search uses
    `fuzzy`'s default implementation, which means that the results can seem
    a little bit off kilter.
    PtrTeixeira committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    2acfe4c View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2017

  1. Fix issues that were raised in code review

    Involved two major changes: migrating the single-page utils code into
    the package utils code, and changing how the request submission was
    handled. In particular, w/r/t the latter, it had been the case that
    there as an action creator in the `api/services.es6` file that was
    responsible for sending remove upstreams requests. That has now been
    removed, in favor of delegating to the more general action creator in
    `api/requests.es6` that can handle any kind of request, and just
    creating the request body at the point where it is triggered.
    PtrTeixeira committed Feb 15, 2017
    Configuration menu
    Copy the full SHA
    2d26254 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2017

  1. Remove extra newline

    PtrTeixeira committed Feb 17, 2017
    Configuration menu
    Copy the full SHA
    dd99f39 View commit details
    Browse the repository at this point in the history