Correctly grab group/rack attributes from model #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way that it was working was that only the name of the upstream being grabbed; it was not looking up the group/rack attributes in the model at all when you attempted to remove a single upstream. This change uses the name of the upstream to lookup the actual upstream object in the model, then posts that request to the server. The values that weren't `upstream` and `requestId` were the defaults; they weren't really coming from anywhere, they were just being filled in.
|
/cc @ssalinas |
|
👍 thanks for finding the bug in this one |
`getByUpstreamName` -> `this.getByUpstreamName`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way that it was working was that only the name of the upstream being
grabbed; it was not looking up the group/rack attributes in the model at
all when you attempted to remove a single upstream. This change uses
the name of the upstream to lookup the actual upstream object in the
model, then posts that request to the server.
The values that weren't
upstreamandrequestIdwere the defaults;they weren't really coming from anywhere, they were just being filled
in.