Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handlebars resolve hostname helper #192

Merged
merged 5 commits into from
Aug 1, 2016
Merged

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Aug 1, 2016

hostname -> first resolved ip or host:port -> ip:port , e.g.

{{#resolveHostname upstream}}

@ssalinas
Copy link
Member Author

ssalinas commented Aug 1, 2016

/fyi @tpetr cleaned up the helpers. Also, apparently to call it without the end bracket, need to cal it as {{{resolveHostname hostname}}} vs {{#resolveHostname hostname}}. Any UnknownHostExceptions will bubble back up and cause the request to fail as expected.

@ssalinas ssalinas merged commit feda140 into master Aug 1, 2016
@ssalinas ssalinas deleted the resolve_ip_helper branch August 1, 2016 16:46
@ssalinas ssalinas removed the staging label Aug 1, 2016
@ssalinas ssalinas modified the milestone: 0.5.0 May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant