switch back to maven-compiler-plugin 3.10.0 (issue #457)

HtmlUnit · Mar 9, 2022 · 6a1b511 · 6a1b511
1 parent 98d3192
commit 6a1b511
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -36,7 +36,7 @@
 
         <!-- As a property, as it is included in Checkstyle build -->
         <checkstyle.version>9.3</checkstyle.version>
-        <spotbugs.version>4.5.3</spotbugs.version>
+        <spotbugs.version>4.6.0</spotbugs.version>
         <pmd.version>6.43.0</pmd.version>
         <archunit.version>0.23.1</archunit.version>
         <dependencycheck.version>7.0.0</dependencycheck.version>
@@ -47,7 +47,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.10.0</version>
+                <version>3.9.0</version>
                 <configuration>
                     <testExcludes>
                         <exclude>**/CodeChecker.java</exclude>

diff --git a/src/test/java/com/gargoylesoftware/htmlunit/ExternalTest.java b/src/test/java/com/gargoylesoftware/htmlunit/ExternalTest.java
@@ -350,11 +350,17 @@ private static boolean isIgnored(@SuppressWarnings("unused") final String groupI
         if ("checkstyle".equals(artifactId) && (version.startsWith("10."))) {
             return true;
         }
-        // version 3.11.x seem to requires
+        // version 3.11.x seem to requires JDK11
         if ("maven-site-plugin".equals(artifactId) && (version.startsWith("3.11."))) {
             return true;
         }
 
+        // there is a serious bug
+        // https://github.com/HtmlUnit/htmlunit/issues/457
+        if ("maven-compiler-plugin".equals(artifactId) && (version.startsWith("3.10.0"))) {
+            return true;
+        }
+
         // really old common versions
         if ("commons-io".equals(artifactId) && (version.startsWith("2003"))) {
             return true;