Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize URLs and confirm canonical URLs #492

Merged
merged 5 commits into from
Aug 4, 2023

Conversation

carlgieringer
Copy link
Contributor

@carlgieringer carlgieringer commented Aug 4, 2023

TODO

Discovered during PR: premiser-ui's webpack.config.ts cannot depend on howdju-common because webpack uses ts-node for ts config files, which does not support importing ES modules (normalize-url is ESM.) If we really need the webpack config to depend on howdju-common, we might try esbuilding the webpack config and then running webpack on the built config.

@carlgieringer carlgieringer added requires schema release PRs that must update the database schema requires lambda release Requires a manual deployment of one or more Lambdas (not the API) labels Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Changed-files coverage summary


=============================== Coverage summary ===============================
Statements   : 58.45% ( 1172/2005 )
Branches     : 45.39% ( 364/802 )
Functions    : 45.29% ( 250/552 )
Lines        : 58.73% ( 1157/1970 )
================================================================================

@carlgieringer carlgieringer changed the title Schedule confirming canonical URL on URL creation Normalize URLs and confirm canonical URLs Aug 4, 2023
Signed-off-by: Carl Gieringer <[email protected]>
@carlgieringer carlgieringer merged commit c0356cc into master Aug 4, 2023
@carlgieringer carlgieringer deleted the features/38-no-dupe-me-urls-in-ui branch August 4, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires lambda release Requires a manual deployment of one or more Lambdas (not the API) requires schema release PRs that must update the database schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant