Make changes necessary to deal with new term #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusha
force-pushed
the
enhancement/term-10
branch
2 times, most recently
from
7964292 to
e14d5d6
Compare
The official data source of which we retrieve the data about political groups has not been updated yet. After the update, it will be necessary to run `htv dev load_groups` again. Until then, we manually inserted the newly formed groups.
Somehow, the `ids` list contained vote ids as strings. As the vote.id is an int, the sort lambda would fail resulting in 500 errors upon /votes/search. This fixes the problem, although the cause is not addressed yet.
linusha
force-pushed
the
enhancement/term-10
branch
from
e14d5d6 to
932e454
Compare
This resolves two issues: 1) The subcondition `date >= brexit_date and count != 705` would have been true for every vote of the 10th term. (This is related to the changes in 731663.) 2) If a vote had multiple issues, only one of them would be persisted, because multiple fragments with the same primary key would have been emitted. (I believe this was a bug since the inception of this code.)
tillprochaska
force-pushed
the
enhancement/term-10
branch
from
1276dcd to
9bef327
Compare
tillprochaska
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains all necessary changes for the recently started 10th term of parliament.
It will be necessary to run
htv dev load-groupsonce more, when the official data sources are updated to reflect the newly formed groups. See #960.