Implement doubly linked list #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshemsedinov
reviewed
Mar 7, 2017
tshemsedinov
requested changes
Mar 7, 2017
JavaScript/doubly_classbased.js
Outdated
| */ | ||
| let current = this.head; | ||
| while (current) { | ||
| if (typeof(current.data) === LinkedList) { |
JavaScript/doubly_classbased.js
Outdated
| if (this.length === 0) { | ||
| this.head = new Node(data); | ||
| this.tail = this.head; | ||
| } |
JavaScript/doubly_classbased.js
Outdated
|
|
||
| pop() { | ||
| if (!this.tail) { | ||
| throw Error('Pop from empty list'); |
There was a problem hiding this comment.
Если только можно не делать throw, его делать не нужно
JavaScript/doubly_classbased.js
Outdated
|
|
||
| findFirst(data) { | ||
| let current = this.head; | ||
| while (current !== null) { |
JavaScript/doubly_classbased.js
Outdated
| let current = this.head; | ||
| let nodes = []; | ||
| while (current !== null) { | ||
| if (current.data |
There was a problem hiding this comment.
if (current.data.toString().match(regex)) {
nodes.push(current);
}или
const matched = current.data.toString().match(regex);
if (matched) nodes.push(current);There was a problem hiding this comment.
Не принято сносить каждый метод на новую строку? Пару раз видел примеры кода с таким стилем.
There was a problem hiding this comment.
Делать это внутри if-условия не хорошо, а в присваивании можно, если в строку не влазит или для концептуальной красоты.
tshemsedinov
requested changes
Mar 7, 2017
JavaScript/doubly_classbased.js
Outdated
| throw Error('Pop from empty list'); | ||
| } | ||
| if (!this.tail) | ||
| return ''; |
JavaScript/doubly_classbased.js
Outdated
| if (this.head) { | ||
| return this.head.toString(); | ||
| } | ||
| return 'Empty list'; |
There was a problem hiding this comment.
Возвращать сообщение об ошибке в строке плохо.
toString() {
if (!this.head) return;
return this.head.toString();
}
JavaScript/doubly_classbased.js
Outdated
| } | ||
|
|
||
| isEmpty() { | ||
| return Boolean(this.length); |
JavaScript/doubly_classbased.js
Outdated
| } | ||
|
|
||
| pop() { | ||
| if (!this.tail) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.