Added support for catalog signed files in local file scans in the AppControl Manager #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for catalog signed files in local file scans
There was a problem hiding this comment.
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- AppControl Manager/MyRoots.xml: Language not supported
- AppControl Manager/global.json: Language not supported
Comments suppressed due to low confidence (3)
AppControl Manager/IntelGathering/LocalFilesScan.cs:55
- The initialization of temporaryOutput is incorrect. It should be new ConcurrentDictionary<FileInfo, FileIdentity>().
ConcurrentDictionary<FileInfo, FileIdentity> temporaryOutput = [];
AppControl Manager/IntelGathering/LocalFilesScan.cs:153
- The variable name fileHashes.SHa1Authenticode is inconsistently cased. It should be fileHashes.SHA1Authenticode.
else if (AllSecurityCatalogHashes.TryGetValue(fileHashes.SHa1Authenticode!, out string? CurrentFilePathHashSHA1CatResult))
AppControl Manager/IntelGathering/LocalFilesScan.cs:157
- The variable name fileHashes.SHA256Authenticode is inconsistently cased. It should be fileHashes.SHA256Authenticode.
else if (AllSecurityCatalogHashes.TryGetValue(fileHashes.SHA256Authenticode!, out string? CurrentFilePathHashSHA256CatResult))
Added security cats support to View File Certificates page
HotCakeX
deleted the
Added-support-for-Catalog-Signed-files-in-local-file-scans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for catalog signed files in local file scans. This is a prerequisite for a successful local driver scans since the majority of them are catalog signed. This also improves the overall accuracy of all file scans in the AppControl Manager.
Added support for catalog signed files to the View File Certificates page.