This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Modified medication model #1065
Merged
jkleinsc
merged 10 commits into
HospitalRun:master
from
hsorellana:fix-medication-model
May 18, 2017
Merged
Modified medication model #1065
jkleinsc
merged 10 commits into
HospitalRun:master
from
hsorellana:fix-medication-model
May 18, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
suggested changes
Apr 26, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsorellana thanks for updating the PR. Can you make the change suggested so that it passes ESLint?
app/models/medication.js
Outdated
let quantityToCompare = null; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are spaces here that are causing ESLint to fail. Can you remove them?
…hospitalrun-frontend into fix-medication-model
jkleinsc
approved these changes
May 18, 2017
Thanks for the update on the PR @hsorellana! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications requested, in a new PR, cause of what i posted on #1064
Same here, suggest that #913 PR should be deleted.
cc @HospitalRun/core-maintainers