Skip to content

Commit

Permalink
ci: Set continue-on-error for matrix jobs
Browse files Browse the repository at this point in the history
Reasoning is we want to extract as much signal as possible in one-shot.
Sometimes PRs can enter a whack-a-mole state where you iteratively fix
one job at a time. This is time consuming and frustrating.

Better to run all the jobs to completion (trade off compute resources
for human time).
  • Loading branch information
danobi committed Jan 22, 2024
1 parent 322cdfa commit 1321ef0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:

build_test:
runs-on: ubuntu-latest
continue-on-error: true
strategy:
matrix:
env:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/distros.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ concurrency:
jobs:
build:
runs-on: ubuntu-latest
continue-on-error: true
strategy:
matrix:
dockerfile:
Expand Down

0 comments on commit 1321ef0

Please sign in to comment.