Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add A21N Leap ACTs #95

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

vikingnope
Copy link

@vikingnope vikingnope commented Jun 5, 2024

I would like feedback if you notice something incorrect or potentially missing, also if someone could answer the questions I left in the code that would be great. This is only a draft till now.

To search for questions type the following:

  • // TODO:
  • // ?
  • // *
  • // !

Summary of Changes

Added ACT 1, 2 and 4 to the A321 Leap

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

I would not suggest any testing before I get the correct CSS positioning for the TankReadoutWidget for ACTs 1, 2 & 4.

Should you want to do testing:

  1. Refuel the aircraft and make sure that all other tanks are filled up before ACTs start to be filled up. These should get filled in this order: ACT1, ACT2, ACT4
  2. Make sure that this fuel has been loaded
  3. Try to unload the fuel
  4. Try a flight and see that when 11300lb (5000 kg) is reached on the centre tank, it starts to fill up from the ACTs in this order: ACT 4, ACT 2, ACT 1

Mark accordingly if they work:

  • Refuel tanks
  • Unload tanks
  • Tanks transfer

I think that is all, if you think I missed something let me know.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@vikingnope vikingnope changed the title A21N Leap ACTs feat: Add A21N Leap ACTs Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant