Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional bytes #421

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Additional bytes #421

merged 5 commits into from
Jun 28, 2022

Conversation

VolodymyrBabaiev
Copy link
Contributor

@VolodymyrBabaiev VolodymyrBabaiev commented Jun 28, 2022

Penalize peer if it sends additional bytes father the modifier. This implementation copied 4 functions of NodeSynchronizer from Scorex. It is better to move implementation to scorex.

@VolodymyrBabaiev VolodymyrBabaiev requested a review from i-Alex June 28, 2022 08:19
@VolodymyrBabaiev VolodymyrBabaiev changed the base branch from master to dev June 28, 2022 08:25
Copy link
Contributor

@i-Alex i-Alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just a few typo in the names

@VolodymyrBabaiev VolodymyrBabaiev marked this pull request as ready for review June 28, 2022 12:39
@i-Alex i-Alex merged commit 652e0c4 into dev Jun 28, 2022
@i-Alex i-Alex deleted the additional_bytes branch February 16, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants