Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.3.5: Snark keys generation fix #404

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Release 0.3.5: Snark keys generation fix #404

merged 2 commits into from
Jun 17, 2022

Conversation

i-Alex
Copy link
Contributor

@i-Alex i-Alex commented Jun 16, 2022

No description provided.

DanieleDiBenedetto
DanieleDiBenedetto approved these changes Jun 16, 2022
View reviewed changes
Copy link

@DanieleDiBenedetto DanieleDiBenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything fine, but I wonder if we could ever make this supportedSegmentSize parameteric. It's true that the performance gap is not huge, but since maxKeys is customizable then also supportedSegmentSize should be

@cronicc cronicc merged commit e4b665e into master Jun 17, 2022
@i-Alex i-Alex deleted the snark_keys_generation_fix branch August 5, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanieleDiBenedetto DanieleDiBenedetto DanieleDiBenedetto approved these changes

@alsala alsala alsala approved these changes

@cronicc cronicc cronicc approved these changes

@lander86 lander86 Awaiting requested review from lander86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@i-Alex @cronicc @alsala @DanieleDiBenedetto