Skip to content

Commit

Permalink
Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
saratnt committed May 14, 2024
1 parent 0f465c2 commit 2ce7b35
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 34 deletions.
16 changes: 8 additions & 8 deletions doc/release/0.12.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ Same format as now, but the output field stakeId will no more be present
The following addition will be included in:<br>

Endpoint: /block/getFeePayments <br>
Rpc endpoint: zen_getFeePayments<br>
Rpc endpoint: zen_getFeePayments<br>

Their result will keep the same format as now, but will also include the reward paid to the address of the smart contracts (if defined).
Their result will keep the same format as now, but will also include the reward paid to the address of the smart contracts (if defined).

We will also detail the amount coming from the mainchain redistribution: to be retrocompatible they will be into additional fields valueFromMainchain and valueFromFees:
We will also detail the amount coming from the mainchain redistribution: to be retrocompatible they will be into additional fields valueFromMainchain and valueFromFees:

```
{
Expand All @@ -56,11 +56,11 @@ We will also detail the amount coming from the mainchain redistribution: to be r
```
### Reward from mainchain - new rules

The maximum ZEN amount redistributed to forgers from the special address 0x000000000000000000003333333333333333333 in a single withdrawal epoch is now limited to a maximum value expressed by the following formula:
The maximum ZEN amount redistributed to forgers from the special address 0x000000000000000000003333333333333333333 in a single withdrawal epoch is now limited to a maximum value expressed by the following formula:

- MAX_VALUE_REDISTRIBUTED = sum [10% of Mainchain’s block-reward Coinbase of each mainchain block reference included in the withdrawal epoch]

- Funds over the limit will stay in the address balance and will be redistributed in the following epochs.
- Funds over the limit will stay in the address balance and will be redistributed in the following epochs.

For example:<br>
Current Mainchain block reward: 6.25 ZEN<br>
Expand All @@ -74,7 +74,7 @@ EON_VERSION/SDK_VERSION/ARCHITECTURE/JAVA_VERSION

- Better error handling: in case of error the response status code will be 400 instead of 200.

- In case of batch requests, the response is now always an array, even with a batch composed of only one element. Previously, if the batch request was composed by only one element, the response was an object.
- In case of batch requests, the response is now always an array, even with a batch composed of only one element. Previously, if the batch request was composed by only one element, the response was an object.

### New metrics endpoint
A new endpoint can be optionally exposed (on a different port from the serverAPI) to show some node metrics.
Expand All @@ -98,7 +98,7 @@ metric_id value

Available metrics:

Following metrics will be available (also listed in the endpoint /metrics/help):
Following metrics will be available (also listed in the endpoint /metrics/help):

- **block_apply_time**<br>
Time to apply block to node wallet and state (milliseconds)
Expand All @@ -123,7 +123,7 @@ Default value for the property:

maxForgerConnections

Has been increased from 20 to 100.
Has been increased from 20 to 100.
(Remember this only applies if no value is set explicitly in conf / docker env).

Furthermore, the dedicated connection pool for forgers nodes (governed by the above property) now only applies if the node is itself a forger.
Expand Down
28 changes: 2 additions & 26 deletions sdk/src/main/resources/account/api/accountApi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1502,24 +1502,6 @@ paths:
summary: Returns the paginated list of forging stakes.
description: Returns the paginated list of forging stakes.
operationId: pagedForgingStakes
requestBody:
content:
application/json:
schema:
type: object
required:
- blockSignPubKey, vrfPubKey, rewardShare, rewardAddress
properties:
startPos:
type: integer
description: Start position in the paginated list
default: 0
size:
type: integer
description: Number of records to return
default: 10
gasInfo:
$ref: '#/components/schemas/EIP1559GasInfo'
responses:
'200':
description: successful operation. If nextPos is == -1 means no additional records, otherwise it is the starting index of the remaining elements.
Expand Down Expand Up @@ -1561,10 +1543,6 @@ paths:
type: string
stakedAmount:
type: integer





default:
description: any kind of http error
Expand Down Expand Up @@ -1599,8 +1577,7 @@ paths:
type: integer
description: Number of records to return
default: 10
gasInfo:
$ref: '#/components/schemas/EIP1559GasInfo'

responses:
'200':
description: successful operation. If nextPos is == -1 means no additional records, otherwise it is the starting index of the remaining elements.
Expand Down Expand Up @@ -1670,8 +1647,7 @@ paths:
type: integer
description: Number of records to return
default: 10
gasInfo:
$ref: '#/components/schemas/EIP1559GasInfo'

responses:
'200':
description: successful operation. If nextPos is == -1 means no additional records, otherwise it is the starting index of the remaining elements.
Expand Down

0 comments on commit 2ce7b35

Please sign in to comment.