avoid conflicts caused by setting install.prefix in distutils.cfg #31811
Conversation
setting `install.prefix` in `distutils.cfg` causes conflicts with other options set on the command-line, such as `--user`. This adds a check to distutils command-line parsing to unset `install.prefix` if such a conflict would be caused by settings from a higher priority source (e.g. command-line).
|
I'd like to see this submitted and discussed upstream before we include it. We only want to include patches of this form that are already on their way upstream rather than using our users as a testing ground for patches. Happy to leave this open until then for discussion. |
|
Fair enough. I'll take a stab at the more generic upstream patch, but it might be more complicated than I am comfortable proposing, whereas the patch here needs only to address the problems caused by setting |
|
I opened an issue upstream. We'll see how it goes. |
|
The upstream patch is stalled for want of review and it's unlikely to be applied to python 2.x. I understand that Debian and Apple apply similar patches. We could ask pip to do something about this (they just pass options through to setup.py, which calls functions from distutils in Python's stdlib). I'm starting to favor carrying a patch like this. |
|
Partially resolved (in pip) by pypa/pip#2934; direct setup.py invocations will still fail without the workaround. |
|
This PR needs to be rebased on top of |
Setting
install.prefixindistutils.cfgcauses conflicts with other options set on the command-line, such as--user. This adds a check to distutils command-line parsing to unsetinstall.prefixif such a conflict would be caused by settings from a higher priority source (e.g. command-line).Supersedes #31803 by hopefully being less gross.
This addresses what I would consider a bug in Python distutils, and thus has the chance of evolving into an upstream patch: settings found in distutils.cfg are treated as if they were typed at the command-line in terms of conflict resolution, rather than as if they were defaults to be overridden. A generic patch for distutils to fix this logic would be more complex, but this simple patch handles the case that affects Homebrew Python as it is today.