Add installed status indicator for deps command #19033
Conversation
|
Any more thoughts on this? |
|
I'll have a look. |
|
This works for me but I'll wait for a +1 from another maintainer. |
|
Does this check |
|
@jacknagel: it does not. Shall I add this check in? What should be the expected behavior? If |
|
|
|
Good point. Fixed. |
|
Changed |
|
Probably needs to be rebased on master. |
|
I took a look, and it's going to need considerable work to rebase. I'll take a shot if I get some time this weekend. |
|
Looking at this now, and the dep calculation got significantly more complex over time. I might try and entirely different approach... |
* display a green checkmark or red x indicating installed? * simply highlight dep to show status if `HOMEBREW_NO_EMOJI` is set * do nothing if stdout is not a tty
|
THIS COMMIT IS SEMI-BROKEN AND NOT YET READY. I've made significant progress, but I'm stuck on formulae where a dependency is noted as a symbol instead of a string. Examples: zpython, zabbix. I've run out of time available this evening. What I think I want to do is to ensure that everything going into the decoration methods is of class Dependency, which it appears to be, except when a dependency is noted as a symbol. I guess I need to figure a way to get a Dependency given a symbol. |
|
@colindean I think that symbol dependency stuff has been changed. |
|
I'll take a look if I get a chance this weekend. |
|
This needs to be rebased on master for further review, but note that @jacknagel is refactoring this part of the code so further breakage is expected. |
|
Passing on this for now. |
HOMEBREW_NO_EMOJIis setSee also #18922. This came out of that discussion.
An opportunity for improvement of this and the eventual result of #18922 is refactoring to have both commands use the same dependency decoration code. If both are accepted, I'll undertake this once I gain an understanding of where this code would live, with the necessity that a user be able to monkeypatch it with their own decorator.