python3: 3.3.0 and supverenv

[samueljohn]

• Added --with-brewed-openssl
• Added back again --universal
• Builds with superenv and env :std
• Write a sitecustomize.py with the fixes
  already applied to python 2.7:
  • Support pip uninstall of scripts
  • Better virtualenv compatibility
• Clean up of caveats.

[samueljohn]

No dependency on x11 any more. But still the tkinter module is working.

[MikeMcQuaid]

How did you fix that?

[adamv]

Note, need to move 3.2.x to versions first.

[samueljohn]

@MikeMcQuaid superenv basically fixed it for me. And Tk does not really need the X11 libs but just some definitions from the headers.

@adamv I hoped to submit this new formula for homebrew-versions/python3.2.too. But I bet you'll do some history-preserving git-magic.

[adamv]

I don't know how to do that magic.

[samueljohn]

@MikeMcQuaid Perhaps, I was wrong about X11, (I forgot, that I at some point actually installed Xquartz).

[samueljohn]

@MikeMcQuaid In the middle of the fight I must have lost this line (which indeed does the promised fix) because in the Tk framework, there are the needed headers.

    # Python does not need all of X11, these bundled Headers are enough
    ENV.append 'CPPFLAGS', "-I#{MacOS.sdk_path}/System/Library/Frameworks/Tk.framework/Versions/8.5/Headers"

I pushed an updated version. brew test -v python3 should work now (it imports tkinter as a test).

@adamv Would you allow an exception of the sqaush into single commit rule here? There are two commits. The first does all the new stuff to python3 (as we do now with python.rb) and the second commit is just for the version bump.

I tested both versions. With Xcode-only and CLT-only on 10.8.

[samueljohn]

Update: Looks like on systems with CLT, the X11 headers are found due to default search paths.
So I added the unless MacOS::CLT.installed?.

[cefstat]

Is there a problem with this pull request that delays it being merged?

[adamv]

Waiting on 3.2 being moved to Homebrew-versions

[samueljohn]

@adamv would it be ok, if I submit the c468cc4 to homebrew-versions?

[samueljohn]

I did https://github.com/Homebrew/homebrew-versions/pull/52 @adamv.

[nathany]

+1 been waiting to play with this and contemplating the python.org installer instead. thanks @samueljohn for all the work.

[samueljohn]

@adamv ?
...we are loosing momentum.
Though, the truth it, I should have prepared python 3.3 before the release, in order to have it shipped on day one. There were some serious issues with the python 2.x formula that kept me busy back then but that's no excuse.

Let's get this finished now asap.

[Zearin]

Agreed. I just found this issue after trying to edit the 3.2 formula to install 3.3. I failed—and it looks like there were lots of barriers beyond the just the one that stopped me. Thanks @samueljohn for your work!

Here’s hoping for a merge soon!

[cefstat]

Adding one more voice for having this merged soon.

[samueljohn]

@adamv seems busy, therefore, politely pinging @MikeMcQuaid @jacknagel and @mxcl.

[adamv]

Er, where does superenv? get set?

[samueljohn]

@adamv I found no better way than superenv?. It's defined in superenv.rb.

If you insist on removing the nesting, I can remove this, @adamv. I think it's quite nice to call

 distutils_fix_superenv(args)
 distutils_fix_stdenv

and having these functions so smart that they know when to act.

[samueljohn]

Anyways, thanks for pulling, @adamv 👍