This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
google-sparsehash 2.0.2 doesn't build on Mac OS 10.11 DP 2 #41087
Labels
Comments
seems like removing the check where the comment says --- /Users/Tonio/Desktop/hashtable_test.cc 2015-06-25 13:26:42.000000000 -0700
+++ src/hashtable_test.cc 2015-06-25 13:26:52.000000000 -0700
@@ -898,11 +898,7 @@
// Now swap back, using the free-function swap
// NOTE: MSVC seems to have trouble with this free swap, not quite
// sure why. I've given up trying to fix it though.
-#ifdef _MSC_VER
other_ht.swap(this->ht_);
-#else
- swap(this->ht_, other_ht);
-#endif
EXPECT_EQ(this->UniqueKey(1), this->ht_.deleted_key());
EXPECT_EQ(this->UniqueKey(2), other_ht.deleted_key()); |
but I'm not sure it makes it work... |
Can you report this to the google-sparsehash developers, please? If you can link to the issue you file, that would be helpful. Thanks! |
Tracking in #40837. Let's get this reported upstream if it hasn't been, Thanks. |
Thank you! Added the upstream report to the list. |
tschoonj
added a commit
to tschoonj/homebrew
that referenced
this issue
Sep 29, 2015
see also Homebrew#41087 The latest Xcode release for Yosemite produces the same error that was previously seen on El Capitan
tschoonj
added a commit
to tschoonj/homebrew
that referenced
this issue
Oct 2, 2015
see also Homebrew#41087 The latest Xcode release for Yosemite produces the same error that was previously seen on El Capitan
tschoonj
added a commit
to tschoonj/homebrew
that referenced
this issue
Oct 2, 2015
see also Homebrew#41087 The latest Xcode release for Yosemite produces the same error that was previously seen on El Capitan
tschoonj
added a commit
to tschoonj/homebrew
that referenced
this issue
Oct 2, 2015
see also Homebrew#41087 The latest Xcode release for Yosemite produces the same error that was previously seen on El Capitan
DomT4
pushed a commit
that referenced
this issue
Oct 2, 2015
see also #41087 The latest Xcode release for Yosemite produces the same error that was previously seen on El Capitan Closes #44438. Signed-off-by: Dominyk Tiller <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
brew install google-sparsehash
does not work on El Capitan DP 2The text was updated successfully, but these errors were encountered: