Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goproxy: avoid hanging #96014

Closed
wants to merge 1 commit into from
Closed

goproxy: avoid hanging #96014

wants to merge 1 commit into from

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 1, 2022

When a timeout is triggered, the ensure block is executed. But this itself has its own Process.wait.

Remove this and also switch the test module to one less prone to hanging.

@Bo98 Bo98 added the CI-no-bottles Merge without publishing bottles label Mar 1, 2022
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Mar 1, 2022
@cho-m cho-m mentioned this pull request Mar 1, 2022
Closed
6 tasks
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@iMichka iMichka mentioned this pull request Mar 1, 2022
Closed
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bo98 @BrewTestBot @SMillerDev