Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bkt 0.5.2 (new formula) #95407

Closed
wants to merge 2 commits into from
Closed

bkt 0.5.2 (new formula) #95407

wants to merge 2 commits into from

Conversation

zbentley
Copy link
Contributor

@zbentley zbentley commented Feb 19, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • **Note: does not pass brew audit yet due to insufficient stars. It's growing in popularity so I expect this to be mergeable soon. ** your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 19, 2022
@carlocab carlocab changed the title New formula: bkt (not popular enough yet) bkt 0.5.2 (new formula) Feb 19, 2022
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 19, 2022
@carlocab
Copy link
Member

This needs to be in the Formula subdirectory and not the root of the repository.

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Feb 21, 2022
@zbentley zbentley marked this pull request as ready for review February 24, 2022 21:37
@zbentley
Copy link
Contributor Author

@carlocab requesting re-review on this when you have time. Thanks!

@carlocab
Copy link
Member

Thanks -- can you rebase (i.e. git rebase origin/master && git push --force) your PR branch? PRs with merge commits can't be merged because of the linear history requirement. Squashing your commits together will also help since I suspect @BrewTestBot will get confused from moving the formula into the Formula subdirectory.

@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Feb 28, 2022
@zbentley
Copy link
Contributor Author

@carlocab I ran that command but it seems to have pretty thoroughly trashed this branch. Is this what you're after or shall I open another branch/PR?

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 28, 2022
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Feb 28, 2022
carlocab
carlocab previously approved these changes Feb 28, 2022
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed that up for you.

@carlocab carlocab added the ready to merge PR can be merged once CI is green label Feb 28, 2022
@zbentley
Copy link
Contributor Author

Fixed that up for you.

Thanks!

Formula/bkt.rb Outdated Show resolved Hide resolved
Co-authored-by: Dawid Dziurla <[email protected]>
@zbentley zbentley requested review from dawidd6 and carlocab February 28, 2022 22:44
@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@zbentley zbentley deleted the zbentley-patch-1 branch March 3, 2022 13:41
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants