dotnet 6.0.100 #92991

asbjornu · 2022-01-12T16:03:29Z

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Formula/dotnet.rb

carlocab

I think we should be able to remove this line:

homebrew-core/Formula/dotnet.rb

Line 24 in a241488

depends_on arch: :x86_64

Formula/dotnet.rb

asbjornu · 2022-02-14T21:58:54Z

Thanks for digging into this, @cho-m! As per dotnet/source-build#2756, I've changed the tag and revision to v6.0.102-source-build. Let's see how that goes! 😃

cho-m · 2022-02-14T22:02:58Z

Thanks for digging into this, @cho-m! As per dotnet/source-build#2756, I've changed the tag and revision to v6.0.102-source-build. Let's see how that goes! 😃

I've tried it locally and it still hit the same issue.

I'm now trying a local build by backtracking to v6.0.100 along with any missing patches. If it works, I'll push the changes here.

Note that CI is going to be blocked until queue frees up since we only allow 2 CI-long-timeout PRs to be active

cho-m · 2022-02-14T23:28:08Z

Local Intel build finally succeeded, though I don't see any linkage to [email protected] and icu4c. If ARM still builds, then should be good on macOS side and can focus on Linux build.

Previously, it took over 6 hours for Linux build of .NET 5, so can only hope that it works as-is.

cho-m · 2022-02-15T03:36:48Z

Didn't expect archi-steam-farm to pass CI test.

As expected, gitversion and dafny both failed as they were built for net5.0.

Locally, I had some trouble compiling gitversion with --runtime osx-arm64. Not sure if this is due to some missing components. If I compile for multiple runtime, then it successfully builds.

Snippet of GitVersion build with diag logs

                     Output Item(s):
                         TargetingPack=
                             Microsoft.NETCore.App
                                     NuGetPackageId=Microsoft.NETCore.App.Ref
                                     NuGetPackageVersion=3.1.0
                                     PackageConflictPreferredPackages=Microsoft.NETCore.App.Ref;Microsoft.NETCore.App.Runtime.linux-arm;Microsoft.NETCore.App.Runtime.linux-arm64;Microsoft.NETCore.App.Runtime.linux-musl-arm64;Microsoft.NETCore.App.Runtime.linux-musl-x64;Microsoft.NETCore.App.Runtime.linux-x64;Microsoft.NETCore.App.Runtime.osx-x64;Microsoft.NETCore.App.Runtime.rhel.6-x64;Microsoft.NETCore.App.Runtime.tizen.4.0.0-armel;Microsoft.NETCore.App.Runtime.tizen.5.0.0-armel;Microsoft.NETCore.App.Runtime.win-arm;Microsoft.NETCore.App.Runtime.win-arm64;Microsoft.NETCore.App.Runtime.win-x64;Microsoft.NETCore.App.Runtime.win-x86
                                     RuntimeFrameworkName=Microsoft.NETCore.App
                                     RuntimePackRuntimeIdentifiers=linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86
                                     TargetFramework=netcoreapp3.1
                                     TargetingPackFormat=
                             Microsoft.AspNetCore.App
                                     NuGetPackageId=Microsoft.AspNetCore.App.Ref
                                     NuGetPackageVersion=3.1.10
                                     PackageConflictPreferredPackages=Microsoft.AspNetCore.App.Ref;Microsoft.AspNetCore.App.Runtime.win-x64;Microsoft.AspNetCore.App.Runtime.win-x86;Microsoft.AspNetCore.App.Runtime.win-arm;Microsoft.AspNetCore.App.Runtime.osx-x64;Microsoft.AspNetCore.App.Runtime.linux-musl-x64;Microsoft.AspNetCore.App.Runtime.linux-musl-arm64;Microsoft.AspNetCore.App.Runtime.linux-x64;Microsoft.AspNetCore.App.Runtime.linux-arm;Microsoft.AspNetCore.App.Runtime.linux-arm64
                                     RuntimeFrameworkName=Microsoft.AspNetCore.App
                                     RuntimePackRuntimeIdentifiers=win-x64;win-x86;win-arm;osx-x64;linux-musl-x64;linux-musl-arm64;linux-x64;linux-arm;linux-arm64
                                     TargetFramework=netcoreapp3.1
                                     TargetingPackFormat= (TaskId:72)
                   Done executing task "ProcessFrameworkReferences". (TaskId:72)
                   Set Property: AppHostRuntimeIdentifier=osx-arm64
                   Using "ResolveAppHosts" task from assembly "/opt/homebrew/Cellar/dotnet/6.0.100/libexec/sdk/6.0.100/Sdks/Microsoft.NET.Sdk/targets/../tools/net6.0/Microsoft.NET.Build.Tasks.dll".
                   Task "ResolveAppHosts" (TaskId:73)
                     Task Parameter:TargetingPackRoot=/opt/homebrew/Cellar/dotnet/6.0.100/libexec/packs (TaskId:73)
                     Task Parameter:DotNetComHostLibraryNameWithoutExtension=comhost (TaskId:73)
                     Task Parameter:NetCoreTargetingPackRoot=/opt/homebrew/Cellar/dotnet/6.0.100/libexec/packs (TaskId:73)
                     Task Parameter:DotNetIjwHostLibraryNameWithoutExtension=Ijwhost (TaskId:73)
                     Task Parameter:
                         KnownAppHostPacks=
                             Microsoft.NETCore.App
                                     AppHostPackNamePattern=Microsoft.NETCore.App.Host.**RID**
                                     AppHostPackVersion=6.0.0
                                     AppHostRuntimeIdentifiers=linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86;linux-musl-arm;osx-arm64;linux-s390x;osx-arm64
                                     TargetFramework=net6.0
                             Microsoft.NETCore.App
                                     AppHostPackNamePattern=Microsoft.NETCore.App.Host.**RID**
                                     AppHostPackVersion=5.0.12
                                     AppHostRuntimeIdentifiers=linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86;linux-musl-arm
                                     TargetFramework=net5.0
                             Microsoft.NETCore.App
                                     AppHostPackNamePattern=Microsoft.NETCore.App.Host.**RID**
                                     AppHostPackVersion=3.1.21
                                     AppHostRuntimeIdentifiers=linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86
                                     TargetFramework=netcoreapp3.1
                             Microsoft.NETCore.App
                                     AppHostPackNamePattern=Microsoft.NETCore.App.Host.**RID**
                                     AppHostPackVersion=3.0.3
                                     AppHostRuntimeIdentifiers=linux-arm;linux-arm64;linux-musl-arm64;linux-musl-x64;linux-x64;osx-x64;rhel.6-x64;tizen.4.0.0-armel;tizen.5.0.0-armel;win-arm;win-arm64;win-x64;win-x86
                                     TargetFramework=netcoreapp3.0 (TaskId:73)
                     Task Parameter:TargetFrameworkIdentifier=.NETCoreApp (TaskId:73)
                     Task Parameter:DotNetAppHostExecutableNameWithoutExtension=apphost (TaskId:73)
                     Task Parameter:DotNetSingleFileHostExecutableNameWithoutExtension=singlefilehost (TaskId:73)
                     Task Parameter:TargetFrameworkVersion=3.1 (TaskId:73)
                     Task Parameter:AppHostRuntimeIdentifier=osx-arm64 (TaskId:73)
                     Task Parameter:RuntimeGraphPath=/opt/homebrew/Cellar/dotnet/6.0.100/libexec/sdk/6.0.100/RuntimeIdentifierGraph.json (TaskId:73)
03:43:42.663  1:20>/opt/homebrew/Cellar/dotnet/6.0.100/libexec/sdk/6.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(129,5): error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'osx-arm64'. [/private/tmp/gitversion-20220214-92998-2kgprj/GitVersion-5.8.1/src/GitVersion.App/GitVersion.App.csproj]

EDIT: macOS dependent results are reasonable:

dafny is expected to fail on Monterey since openjdk@11 isn't bottled yet.
gitversion is failing on both ARM due to above error.
archi-steam-farm build/test passes

Now waiting on Linux...

arturcic · 2022-02-16T23:02:11Z

Locally, I had some trouble compiling gitversion with --runtime osx-arm64. Not sure if this is due to some missing components. If I compile for multiple runtime, then it successfully builds.

I think there is an additional -p:OsxArm64=true that needs to be added only for arm64 osx

carlocab · 2022-02-17T01:17:34Z

dotnet bottle build failed on Catalina, but building it from source succeeded when building dotnet as a dependency of archi-steam-farm. Hoping that was just a fluke, so I've restarted the build.

cho-m · 2022-02-17T05:25:31Z

Some things that need to be checked/done:

Upstream local patches
Do we need to manually delete /tmp/dotnet-sources/, which would be 40+ GB at end of PR? I'm not sure about how CI runners are cleaned up between PRs. Currently, I did not do a sourcesdir.rmtree as logic is based on swift's out-of-buildpath logic - dotnet: ensure sources are cleaned up after install #95302
Check for llvm (and gcc-11, which is installed as dependency) linkage on Linux.
- Libs are within gcc-5's glibc/cxx. Low priority of checking libunwind usage as it isn't linked.

Things that can be done in separate PR or here:

Continue looking into getting update to v6.0.102-source-build - dotnet 6.0.102 #95339

Fix dafny build on Linux - dafny: fix Linux build #95334

  ==> ./configure
  'python' not found. Try to set the environment variable PYTHON.

Fix ARM build for gitversion. -p:OsxArm64=true did work locally - gitversion: fix build on macOS ARM #95305

❯ file /opt/homebrew/Cellar/gitversion/5.8.1/libexec/*
/opt/homebrew/Cellar/gitversion/5.8.1/libexec/GitVersion.xml:        XML 1.0 document text, ASCII text
/opt/homebrew/Cellar/gitversion/5.8.1/libexec/gitversion:            Mach-O 64-bit executable arm64
/opt/homebrew/Cellar/gitversion/5.8.1/libexec/libgit2-b7bad55.dylib: Mach-O 64-bit dynamically linked shared library arm64

carlocab · 2022-02-17T05:36:51Z

Linux linkage you can see here: https://github.com/Homebrew/homebrew-core/runs/5225699996?check_suite_focus=true#step:9:12

carlocab

I'd like to get this shipped since a number of other PRs have been waiting for this update.

Thanks, @asbjornu, @cho-m!

cho-m · 2022-02-17T06:24:56Z

I'd like to get this shipped since a number of other PRs have been waiting for this update.

@carlocab Fine with me as the items can be explored outside merge.

I was mainly worried about /tmp space since I saw deno PR just run out-of-space on Monterey CI and was wondering if it was possible for leftover data to leak between PRs. Don't know exact reason for issue there though since I haven't accessed CI runners.

BrewTestBot · 2022-02-17T08:28:09Z

@SMillerDev has triggered a merge.

SMillerDev

Thanks @asbjornu and @cho-m ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

Bo98 · 2022-02-17T12:04:39Z

Do we need to manually delete /tmp/dotnet-sources/, which would be 40+ GB at end of PR? I'm not sure about how CI runners are cleaned up between PRs. Currently, I did not do a sourcesdir.rmtree as logic is based on swift's out-of-buildpath logic.

This should be fixed with high priority. This does not happen with Swift as buildpath.parent is still within the the formula's temp directory. This is not the case for git clone formulae, so buildpath.parent is not safe here.

cho-m · 2022-02-17T12:30:36Z

Do we need to manually delete /tmp/dotnet-sources/, which would be 40+ GB at end of PR? I'm not sure about how CI runners are cleaned up between PRs. Currently, I did not do a sourcesdir.rmtree as logic is based on swift's out-of-buildpath logic.

This should be fixed with high priority. This does not happen with Swift as buildpath.parent is still within the the formula's temp directory. This is not the case for git clone formulae, so buildpath.parent is not safe here.

I was worried about that. Probably need to clean out some of CI runners since there may be some leftover data.

Would something like following work for moving into subdirectories:

--- a/Formula/dotnet.rb
+++ b/Formula/dotnet.rb
@@ -71,10 +71,12 @@ class Dotnet < Formula
     # TODO: Remove this in future release with .NET runtime v6.0.2+
     (buildpath/"src/SourceBuild/tarball/patches/runtime").install resource("runtime-clang13-patch")

-    sourcedir = buildpath.parent/"dotnet-sources"
-    system "./build.sh", "/p:ArcadeBuildTarball=true",
-                         "/p:TarballDir=#{sourcedir}"
-    cd sourcedir
+    (buildpath/"installer").install buildpath.children
+    cd "installer" do
+      system "./build.sh", "/p:ArcadeBuildTarball=true",
+                           "/p:TarballDir=#{buildpath}/sources"
+    end
+    cd "sources"
     # Disable package validation in source-build for reliability
     # PR ref: https://github.com/dotnet/runtime/pull/60881
     # TODO: Remove this in the next release

carlocab · 2022-02-17T12:40:32Z

Does the TarballDir have to be next to the directory where the installer repo is cloned?

cho-m · 2022-02-17T12:41:45Z

Does the TarballDir have to be next to the directory where the installer repo is cloned?

No, just somewhere outside the installer repo

carlocab · 2022-02-17T12:45:22Z

Ok, then I think #95302 should hopefully do the trick.

BrewTestBot added the no ARM bottle Formula has no ARM bottle label Jan 12, 2022

asbjornu force-pushed the feature/dotnet6 branch from 177025d to 3ff643f Compare January 12, 2022 16:05

This was referenced Jan 12, 2022

.NET Source-build instructions dotnet/source-build#2602

Closed

gitversion 5.8.0 #89272

Closed

carlocab reviewed Jan 12, 2022

View reviewed changes

Formula/dotnet.rb Outdated Show resolved Hide resolved

carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jan 12, 2022

carlocab reviewed Jan 12, 2022

View reviewed changes

Formula/dotnet.rb Outdated Show resolved Hide resolved

samuel-lucas6 mentioned this pull request Jan 17, 2022

kryptor 3.1.0 (new formula) #93267

Closed

6 tasks

cho-m reviewed Jan 24, 2022

View reviewed changes

Formula/dotnet.rb Outdated Show resolved Hide resolved

cho-m mentioned this pull request Jan 24, 2022

dotnet 5.0.209.1 #92194

Closed

cho-m added CI-linux-self-hosted Build on Linux self-hosted runner CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing labels Feb 12, 2022

cho-m force-pushed the feature/dotnet6 branch from 3ff643f to 6d516fb Compare February 12, 2022 17:46

carlocab reviewed Feb 12, 2022

View reviewed changes

Formula/dotnet.rb Outdated Show resolved Hide resolved

cho-m force-pushed the feature/dotnet6 branch from 6d516fb to 5505d16 Compare February 12, 2022 19:12

cho-m changed the title ~~dotnet 6.0.100~~ dotnet 6.0.102 Feb 12, 2022

cho-m force-pushed the feature/dotnet6 branch from 5505d16 to 5756824 Compare February 13, 2022 05:07

cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 13, 2022

asbjornu force-pushed the feature/dotnet6 branch from 5756824 to 22d6d2d Compare February 14, 2022 21:57

cho-m force-pushed the feature/dotnet6 branch from 22d6d2d to ffc5866 Compare February 14, 2022 22:59

cho-m changed the title ~~dotnet 6.0.102~~ dotnet 6.0.100 Feb 14, 2022

carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 15, 2022

This comment was marked as resolved.

Sign in to view

cho-m force-pushed the feature/dotnet6 branch from ffc5866 to a4450aa Compare February 15, 2022 05:04

fabiomadge mentioned this pull request Feb 15, 2022

dafny 3.4.1 #95148

Closed

6 tasks

asbjornu and others added 6 commits February 16, 2022 13:12

dotnet 6.0.100

a6ac1c3

archi-steam-farm 5.2.2.5

a7a3d3b

dafny 3.4.0

c81af26

gitversion 5.8.0

531fa5a

gitversion 5.8.1

9aa785c

dafny 3.4.1

bd8a56c

cho-m force-pushed the feature/dotnet6 branch from e699d02 to bd8a56c Compare February 16, 2022 21:14

cho-m removed CI-issue Failure due to temporary CI issue linux Linux is specifically affected labels Feb 16, 2022

carlocab approved these changes Feb 17, 2022

View reviewed changes

carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 17, 2022

cho-m added ready to merge PR can be merged once CI is green and removed in progress Stale bot should stay away labels Feb 17, 2022

SMillerDev approved these changes Feb 17, 2022

View reviewed changes

BrewTestBot closed this in fac0447 Feb 17, 2022

asbjornu deleted the feature/dotnet6 branch February 17, 2022 10:21

cho-m mentioned this pull request Feb 18, 2022

dotnet 6.0.102 #95339

Closed

6 tasks

asbjornu mentioned this pull request Feb 18, 2022

Homebrew formula for .NET 6 dotnet/source-build#2719

Closed

erikbra mentioned this pull request Sep 2, 2022

Publish to homebrew erikbra/grate#61

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dotnet 6.0.100 #92991

dotnet 6.0.100 #92991

asbjornu commented Jan 12, 2022

carlocab left a comment

asbjornu commented Feb 14, 2022

cho-m commented Feb 14, 2022

cho-m commented Feb 14, 2022

This comment was marked as resolved.

cho-m commented Feb 15, 2022 •

edited

Loading

arturcic commented Feb 16, 2022 •

edited

Loading

carlocab commented Feb 17, 2022

cho-m commented Feb 17, 2022 •

edited

Loading

carlocab commented Feb 17, 2022

carlocab left a comment

cho-m commented Feb 17, 2022

BrewTestBot commented Feb 17, 2022

SMillerDev left a comment

Bo98 commented Feb 17, 2022

cho-m commented Feb 17, 2022

carlocab commented Feb 17, 2022

cho-m commented Feb 17, 2022

carlocab commented Feb 17, 2022

dotnet 6.0.100 #92991

dotnet 6.0.100 #92991

Conversation

asbjornu commented Jan 12, 2022

carlocab left a comment

Choose a reason for hiding this comment

asbjornu commented Feb 14, 2022

cho-m commented Feb 14, 2022

cho-m commented Feb 14, 2022

This comment was marked as resolved.

cho-m commented Feb 15, 2022 • edited Loading

arturcic commented Feb 16, 2022 • edited Loading

carlocab commented Feb 17, 2022

cho-m commented Feb 17, 2022 • edited Loading

carlocab commented Feb 17, 2022

carlocab left a comment

Choose a reason for hiding this comment

cho-m commented Feb 17, 2022

BrewTestBot commented Feb 17, 2022

SMillerDev left a comment

Choose a reason for hiding this comment

Bo98 commented Feb 17, 2022

cho-m commented Feb 17, 2022

carlocab commented Feb 17, 2022

cho-m commented Feb 17, 2022

carlocab commented Feb 17, 2022

cho-m commented Feb 15, 2022 •

edited

Loading

arturcic commented Feb 16, 2022 •

edited

Loading

cho-m commented Feb 17, 2022 •

edited

Loading