Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-cli: migrate to [email protected] #86758

Closed
wants to merge 1 commit into from
Closed

azure-cli: migrate to [email protected] #86758

wants to merge 1 commit into from

Conversation

branchvincent
Copy link
Member

azure-cli: migrate to [email protected]

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Oct 7, 2021
@branchvincent
Copy link
Member Author

error in PyGithub setup command: use_2to3 is invalid.

@chenrui333 chenrui333 added python-3.10-migration build failure CI fails while building the software labels Oct 7, 2021
@branchvincent
Copy link
Member Author

see Azure/azure-cli#19857

@jiasli jiasli mentioned this pull request Oct 26, 2021
Merged
@branchvincent
Copy link
Member Author

superseded #88586

@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Nov 2, 2021
@branchvincent branchvincent mentioned this pull request Nov 3, 2021
Closed
@jiasli
Copy link

jiasli commented Nov 5, 2021

We have finished the work for Python 3.10: Azure/azure-cli#20195. Please feel free to change the formula.

@tuzi3040
Copy link
Contributor

Seems we can reopen this PR now. @branchvincent

Also, azure-cli cannot function properly on python 3.9.8 Azure/azure-cli#20269, which is cause by a bugfix (python/cpython#28420) introduced in 3.9.8. This bugfix is now reverted (python/cpython#29525) in both 3.9 and 3.10 branch, but hadn't been released into official 3.10 release, so 3.10 is not affected by it.

@branchvincent branchvincent reopened this Nov 14, 2021
@branchvincent branchvincent added ready to merge PR can be merged once CI is green and removed build failure CI fails while building the software superseded PR was replaced by another PR labels Nov 14, 2021
@jiasli
Copy link

jiasli commented Nov 15, 2021 •
edited
Loading

This PR looks good to me. Please merge it as as soon as possible as users are affected by the Python 3.9.8 regression (Azure/azure-cli#20269).

@jiasli jiasli mentioned this pull request Nov 15, 2021
Closed
@tuzi3040

This comment has been minimized.

Sign in to view
@jiasli jiasli mentioned this pull request Nov 15, 2021
Closed
@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@branchvincent
Copy link
Member Author

thanks @jiasli and @tuzi3040 for the ping and letting us know about the issue!

@jiasli jiasli mentioned this pull request Nov 16, 2021
Closed
@jiasli jiasli mentioned this pull request Nov 16, 2021
Closed
@jiasli jiasli mentioned this pull request Nov 26, 2021
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.10-migration ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@branchvincent @jiasli @tuzi3040 @BrewTestBot @SMillerDev @chenrui333