Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node@4 4.7.2 #8515

Closed
wants to merge 3 commits into from
Closed

node@4 4.7.2 #8515

wants to merge 3 commits into from

Conversation

febLey
Copy link
Contributor

@febLey febLey commented Jan 5, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@ilovezfs ilovezfs added the legacy Relates to a versioned @ formula label Jan 5, 2017
@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 5, 2017

@BrewTestBot test this please

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 5, 2017

@febLey do we know why that checksum changed?

@febLey
Copy link
Contributor Author

febLey commented Jan 5, 2017

I've pasted the wrong checksum, I copied the checksum from the release post, which was the first one, but it seems that this sum was incorrect:

https://nodejs.org/en/blog/release/v4.7.1/

This file contains the correct sum:

https://nodejs.org/dist/v4.7.1/SHASUMS256.txt

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 5, 2017

Thanks for explaining!

@febLey
Copy link
Contributor Author

febLey commented Jan 6, 2017

Here's the according issue:

nodejs/build#586

@febLey
Copy link
Contributor Author

febLey commented Jan 6, 2017

node 4.7.2 with the correct hashes was released. Should I update this PR or create a new one?

https://nodejs.org/en/blog/release/v4.7.2/

@MikeMcQuaid
Copy link
Member

Should I update this PR

That'd be great, thanks 👍

@nijikon nijikon changed the title node@4 4.7.1 node@4 4.7.2 Jan 7, 2017
@nijikon
Copy link
Contributor

nijikon commented Jan 7, 2017

You are awesome, thanks for your contribution! 🎉

@nijikon nijikon closed this in 24d92b1 Jan 7, 2017
@febLey febLey deleted the node@4 branch January 9, 2017 10:50
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy Relates to a versioned @ formula
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants