Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdu: rename binary not to conflict with coreutils #74871

Closed
wants to merge 2 commits into from

Conversation

dundee
Copy link
Contributor

@dundee dundee commented Apr 9, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 9, 2021
@carlocab carlocab changed the title rename gdu binary not to conflict with coreutils gdu: rename binary not to conflict with coreutils Apr 9, 2021
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dundee.

Could you split your commits into two, with one commit modifying gdu, and the other modifying coreutils?

Please also use the preferred commit-message style in homebrew/core, where the formula name comes first. For example, you might use

gdu: rename binary not to conflict with coreutils
coreutils: remove conflict with gdu

@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Apr 9, 2021
@dundee
Copy link
Contributor Author

dundee commented Apr 9, 2021

Thanks, @dundee.

Could you split your commits into two, with one commit modifying gdu, and the other modifying coreutils?

Please also use the preferred commit-message style in homebrew/core, where the formula name comes first. For example, you might use

gdu: rename binary not to conflict with coreutils
coreutils: remove conflict with gdu

Sure, changed.

@dundee dundee closed this Apr 9, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label May 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants