Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic option for nomad #7246

Closed
wants to merge 2 commits into from
Closed

Add dynamic option for nomad #7246

wants to merge 2 commits into from

Conversation

ProbablyRusty
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • Add option “with-dynamic” to nomad, in order to optionally build with CGO_ENABLED
  • This is a common use case for some VPN users on Mac OS X
  • See: Add dynamic option for vault #7238

@MikeMcQuaid
Copy link
Member

See #7238 (comment)

@ProbablyRusty ProbablyRusty mentioned this pull request Nov 26, 2016
4 tasks
@ProbablyRusty
Copy link
Contributor Author

@MikeMcQuaid in light of #7238 can we remove Do Not Merge on this as well?

- Add option “with-dynamic” to nomad, in order to optionally build with CGO_ENABLED
- This is a common use case for some VPN users on Mac OS X
- See:   #7238
@MikeMcQuaid
Copy link
Member

@BrewTestBot test this please

@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

For future reference the preferred commit message format is nomad: add dynamic option.. Please complete the issue template in future PRs where this format is detailed in the linked Contributing guidelines. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants