goredo 0.12.3 (new formula) #68846

kaihendry · 2021-01-12T04:11:27Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

SMillerDev · 2021-01-12T07:44:39Z

Formula/goredo.rb

+class Goredo < Formula
+  desc "Go implementation of djb's redo, a Makefile replacement that sucks less"
+  homepage "http://www.goredo.cypherpunks.ru/"
+  url "http://www.goredo.cypherpunks.ru/download/goredo-0.11.0.tar.zst"


Is there no tar.gz?

Correct, only zstd http://www.goredo.cypherpunks.ru/Install.html

Used by default in Arch and Fedora IIUC

SMillerDev · 2021-01-12T07:45:05Z

Formula/goredo.rb

+    goredo_prefix = "goredo-#{version}"
+    system "tar", "--use-compress-program", "unzstd", "-xvf", "#{goredo_prefix}.tar.zst"
+    cd goredo_prefix do
+      ENV["GOPATH"] = Pathname.pwd


This shouldn't be needed with modern Go programs AFAIK.

It is when you distribute it with all its dependencies like Sergey has chosen to do.

No need to fetch dependencies from the Internet.

golang/go#30329

So yes: the current plan is to deprecate GOPATH in Go 1.13 (scheduled for August 2019).

TIL! With the help of the author Sergey, we've migrated to Go modules.

SMillerDev · 2021-01-12T07:46:03Z

Formula/goredo.rb

+      system "go", "build", *std_go_args, "go.cypherpunks.ru/goredo"
+    end
+    cd bin do
+      system "./goredo", "-symlinks"


Does this mean there is a definition of what to symlink defined in bin?

I'm not sure what you're are saying, it basically a dist helper function to create the various redo-* symlinks to the binary.

Where does the definition about those symlinks live?

http://www.git.cypherpunks.ru/?p=goredo.git;a=blob;f=main.go;h=ed82856be37f842e6c66f9a0607d191388cb40ac;hb=HEAD#l76

I guess I could set them up explicitly manually in the package. Wdyt?

I was expecting there to be some definition file. But if it's hardcoded I guess that's fine.

So no changes required? I'm not sure what the next steps are. Do I mark the conversations are resolved? Not sure what to make of the "Resolve conversation" button.

SMillerDev · 2021-01-12T07:46:15Z

Formula/goredo.rb

+  end
+
+  test do
+    assert_match version.to_s, shell_output("#{bin}/redo-ifchange --version")


We need a test that exercises the some of the functionality of the app. Version checks or usage checks (foo --version or foo --help) are not sufficient, as explained in the formula cookbook.

In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.

Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)

You can also check that an output file was created, if that is expected: assert_predicate testpath/"output.txt", :exist?

Some advice for specific cases:

If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.

If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.

If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.

Same if the software requires a virtual machine, docker instance, etc. to be running.

I added a test:

redo command existence

-no-progress -- tests that it is goredo implementation, having that option

ability of .do file searching

ability of .do file running with the working shell (if OS does not have /bin/sh, then it will fail, as an example)

carlocab · 2021-01-13T22:02:45Z

Your goredo -symlinks step is failing on ARM:

==> ./goredo -symlinks
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
lukechampine.com/blake3.init.0()
	lukechampine.com/[email protected]/cpu_darwin.go:20 +0xfc

Formula/goredo.rb

carlocab

Thanks for your first contribution to homebrew/core, @kaihendry! I hope it's the first of many.

BrewTestBot · 2021-01-14T14:29:36Z

@carlocab has triggered a merge.

BrewTestBot · 2021-01-14T14:30:26Z

⚠️ @carlocab bottle publish failed.

bottle publish failed

BrewTestBot · 2021-01-14T14:54:11Z

@carlocab has triggered a merge.

BrewTestBot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Jan 12, 2021

kaihendry changed the title ~~Package http://www.goredo.cypherpunks.ru/Install.html~~ goredo 0.11.0 (new formula) Jan 12, 2021

kaihendry force-pushed the master branch from b6e8ad1 to 988be6c Compare January 12, 2021 06:49

SMillerDev reviewed Jan 12, 2021

View reviewed changes

carlocab added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 12, 2021

kaihendry force-pushed the master branch from 988be6c to dd7ee35 Compare January 13, 2021 09:14

kaihendry changed the title ~~goredo 0.11.0 (new formula)~~ goredo 0.12.0 (new formula) Jan 13, 2021

kaihendry force-pushed the master branch from dd7ee35 to 75ca2f7 Compare January 13, 2021 13:39

kaihendry changed the title ~~goredo 0.12.0 (new formula)~~ goredo 0.12.1 (new formula) Jan 13, 2021

Package http://www.goredo.cypherpunks.ru/Install.html

66cde33

kaihendry force-pushed the master branch from 75ca2f7 to 66cde33 Compare January 14, 2021 02:45

carlocab reviewed Jan 14, 2021

View reviewed changes

Formula/goredo.rb Show resolved Hide resolved

kaihendry changed the title ~~goredo 0.12.1 (new formula)~~ goredo 0.12.3 (new formula) Jan 14, 2021

carlocab previously approved these changes Jan 14, 2021

View reviewed changes

carlocab approved these changes Jan 14, 2021

View reviewed changes

BrewTestBot closed this in 7386c76 Jan 14, 2021

BrewTestBot added the outdated PR was locked due to age label Feb 14, 2021

Homebrew locked as resolved and limited conversation to collaborators Feb 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

goredo 0.12.3 (new formula) #68846

goredo 0.12.3 (new formula) #68846

kaihendry commented Jan 12, 2021

SMillerDev Jan 12, 2021

kaihendry Jan 13, 2021

SMillerDev Jan 12, 2021

kaihendry Jan 13, 2021

SMillerDev Jan 13, 2021

kaihendry Jan 13, 2021

SMillerDev Jan 12, 2021

kaihendry Jan 13, 2021

SMillerDev Jan 13, 2021

kaihendry Jan 13, 2021

SMillerDev Jan 13, 2021

kaihendry Jan 13, 2021

SMillerDev Jan 12, 2021

kaihendry Jan 13, 2021

carlocab commented Jan 13, 2021

carlocab left a comment

BrewTestBot commented Jan 14, 2021

BrewTestBot commented Jan 14, 2021

BrewTestBot commented Jan 14, 2021

goredo 0.12.3 (new formula) #68846

goredo 0.12.3 (new formula) #68846

Conversation

kaihendry commented Jan 12, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlocab commented Jan 13, 2021

carlocab left a comment

Choose a reason for hiding this comment

BrewTestBot commented Jan 14, 2021

BrewTestBot commented Jan 14, 2021

BrewTestBot commented Jan 14, 2021