Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GOPATH from formulae that already have :arm64_big_sur bottle #68485

Closed
wants to merge 16 commits into from

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jan 7, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This PR removes usage of GOPATH for formulae that already have arm64_big_sur bottles (ie. these formulae are buildable using go modules because we use go1.16 for building arm64_big_sur and go1.16 using modules by default)

dehydrated doesn't actually use go at all 🤷

I believe it's safe enough to do in a single PR and revision bump is not required. Please let me know if I'm mistaken.

@bayandin bayandin changed the title Do not use GOPATH for formulae that have :arm64_big_sur bottle Remove GOPATH from formulae that already have :arm64_big_sur bottle Jan 7, 2021
@fxcoudert
Copy link
Member

On 11-arm, one build failure:

==> go build -trimpath -o /opt/homebrew/Cellar/go-statik/0.1.7/bin/go-statik -ldflags -s -w
Error: An exception occurred within a child process:
  Errno::ENOENT: No such file or directory @ rb_file_s_rename - (/opt/homebrew/Cellar/go-statik/0.1.7/bin/go-static, /opt/homebrew/Cellar/go-statik/0.1.7/bin/statik)

and one test failure, might be network-related:

==> /opt/homebrew/Cellar/darksky-weather/0.15.7/bin/weather
http request to https://geocode.jessfraz.com/forecast failed with status code: 403

@fxcoudert
Copy link
Member

Oops, sorry, didn't mean to cancel the remaining tests :( fat fingers
I guess it's better to fix go-statik first, and then re-run them?

@bayandin
Copy link
Member Author

bayandin commented Jan 7, 2021

==> go build -trimpath -o /opt/homebrew/Cellar/go-statik/0.1.7/bin/go-statik -ldflags -s -w
Error: An exception occurred within a child process:
  Errno::ENOENT: No such file or directory @ rb_file_s_rename - (/opt/homebrew/Cellar/go-statik/0.1.7/bin/go-static, /opt/homebrew/Cellar/go-statik/0.1.7/bin/statik)

Ah, silly typo, it's statik not static :|

Fixed!

@bayandin
Copy link
Member Author

bayandin commented Jan 7, 2021

==> /opt/homebrew/Cellar/darksky-weather/0.15.7/bin/weather
http request to https://geocode.jessfraz.com/forecast failed with status code: 403

Regarding this one, taking into account https://blog.darksky.net/dark-sky-has-a-new-home/ (API is going to be shut at the end of 2021, and they don't provide new API keys), I don't see it's going back to work (see genuinetools/weather#74).

But it's strange that the formula has quite a number of installs: install: 47 (30 days), 139 (90 days), 658 (365 days), maybe they have and use their own API keys...

@bayandin
Copy link
Member Author

bayandin commented Jan 8, 2021

But it's strange that the formula has quite a number of installs: install: 47 (30 days), 139 (90 days), 658 (365 days), maybe they have and use their own API keys...

Ah, apparently, sometimes it works:

$ weather -l London
                          .':loolc;.
                       .o0NNNXKKKXNNXk:
                  .,::kXNKo,.     .:kXNXo:;,.
               ;kXNNNNNXc            .xNNNNNNKd.
             .0NNk:',:odccc:,.         ....,lKNXd
            .KNXdlOXNNNNNNNNNNXOo,            dNNd
            cXNNNNKd:'.    .';o0NNKl.         .NNX
      .';cccxNNXd'              .oXNXoccc;'.  ,NNK
   .cOXNNNNNNNO.                  .kNNNNNNNXOoXNX'
  oXNXx;..  ..                      ..   .;dXNNX.
.ONNd.                                      .oXNO.
xNNo                                          lNNk
XNN.                                          .NNX
0NN,                                          .NNK
;XN0.                                        .ONNc
 ;XNXo.        .                           .lXNX:
  .dXNX0dlcclx0Xo.              .oXKxoccldOXNXx.
     ,ok0XXXX0kKNN0o;'.    ..;o0NNKk0KXXX0ko,
                'lOXNNNNNNNNNNXOo,
                    :x0XNNX0x:.

Current weather is Overcast in London in England for January 8 at 10:30am GMT
The temperature is -0.35°C

  Ick! The humidity is 93.00%
  The nearest storm is 18.0 miles ESE away
  The wind speed is 1.35 mph NE
  The cloud coverage is 98.00%
  The pressure is 1018.2 mbar

Partly cloudy throughout the day.

Rain chance: ▁▁    ▁▁                ▁▁ ▁▁ ▁▁ ▁▁ ▁▁          
             10a         2p          6p          10p         

@fxcoudert
Copy link
Member

@bayandin I don't think you need an API and API keys to predict that the weather in London is "overcast and high humidity". It may be hardcoded in the source code 😄

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@bayandin bayandin deleted the deprecate-gopath branch January 8, 2021 12:41
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 8, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants