-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GOPATH from formulae that already have :arm64_big_sur bottle #68485
Conversation
1bbabd2
to
e4adc97
Compare
On 11-arm, one build failure:
and one test failure, might be network-related:
|
Oops, sorry, didn't mean to cancel the remaining tests :( fat fingers |
Ah, silly typo, it's Fixed! |
e4adc97
to
f2c9b52
Compare
Regarding this one, taking into account https://blog.darksky.net/dark-sky-has-a-new-home/ (API is going to be shut at the end of 2021, and they don't provide new API keys), I don't see it's going back to work (see genuinetools/weather#74). But it's strange that the formula has quite a number of installs: |
Ah, apparently, sometimes it works:
|
@bayandin I don't think you need an API and API keys to predict that the weather in London is "overcast and high humidity". It may be hardcoded in the source code 😄 |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?This PR removes usage of GOPATH for formulae that already have
arm64_big_sur
bottles (ie. these formulae are buildable using go modules because we use go1.16 for building arm64_big_sur and go1.16 using modules by default)dehydrated
doesn't actually usego
at all 🤷I believe it's safe enough to do in a single PR and revision bump is not required. Please let me know if I'm mistaken.