Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cedille: build with haskell-stack #67282

Closed
wants to merge 1 commit into from

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@SeekingMeaning SeekingMeaning added the cabal v1 deprecation Deprecate cabal sandbox label Dec 20, 2020
@BrewTestBot BrewTestBot added the haskell Haskell use is a significant feature of the PR or issue label Dec 20, 2020
@carlocab
Copy link
Member

Does cedille also need alex and happy, or was that just to build agda? Because there should be alex and happy binaries in agda's libexec.

@SeekingMeaning
Copy link
Contributor Author

SeekingMeaning commented Dec 20, 2020

Hmm, that's a good question, I'm not sure myself

@carlocab
Copy link
Member

carlocab commented Dec 20, 2020

Well, CI passed.. so I guess not?

Unless it actually built its own agda to bootstrap with without telling you No, this isn't possible. Building agda takes about an hour.

@chenrui333
Copy link
Member

lgtm. 💯

@chenrui333
Copy link
Member

Does cedille also need alex and happy, or was that just to build agda? Because there should be alex and happy binaries in agda's libexec.

I got inferred from the stack.yaml, so that is vendored in the build process (we will need to look at it later)

@carlocab
Copy link
Member

carlocab commented Dec 20, 2020

I got inferred from the stack.yaml, so that is vendored in the build process

So that means it installed its own alex and happy?

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@chenrui333
Copy link
Member

I got inferred from the stack.yaml, so that is vendored in the build process

So that means it installed its own alex and happy?

to my understanding, yes. you can also check discussions on this PR, Homebrew/brew#6945

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 20, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cabal v1 deprecation Deprecate cabal sandbox haskell Haskell use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants