-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbmate 1.11.0 #65167
dbmate 1.11.0 #65167
Conversation
451a3cc
to
97f6d78
Compare
I can't see any reason why this test is failing on 10.15: /usr/local/Cellar/dbmate/1.11.0/bin/dbmate: cannot execute binary file The build is very simple: def install
system "go", "build", "-ldflags", "-s", "-o", bin/"dbmate", "."
end It works perfectly on 10.14 and 11.0, but fails on 10.15. Any ideas? |
Yeah, this is probably the Catalina tar bug again: Homebrew/brew#6539 |
5ac7874
to
c7aaf64
Compare
Interesting. I added some debugging lines to CI, and apparently the binary is just "data": ==> ls -al /usr/local/Cellar/dbmate/1.11.0/bin/dbmate
-r-xr-xr-x 1 brew staff 10600768 Nov 19 02:04 /usr/local/Cellar/dbmate/1.11.0/bin/dbmate
==> file /usr/local/Cellar/dbmate/1.11.0/bin/dbmate
/usr/local/Cellar/dbmate/1.11.0/bin/dbmate: data
==> /usr/local/Cellar/dbmate/1.11.0/bin/dbmate create
/usr/local/Cellar/dbmate/1.11.0/bin/dbmate: /usr/local/Cellar/dbmate/1.11.0/bin/dbmate: cannot execute binary file
Error: dbmate: failed Interestingly, it works on my local Catalina machine. It sounds like the only workaround is for a homebrew maintainer to manually remove the Catalina bottle? |
I believe this is ready to merge despite the CI failure on Catalina. If there is anything I can do to resolve the failure please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will reenable a work-around the Catalina bug, and we can merge once that is done
Formula/dbmate.rb
Outdated
license "MIT" | ||
head "https://github.com/amacneil/dbmate.git" | ||
|
||
bottle do | ||
cellar :any_skip_relocation | ||
sha256 "1c3359021c62b14a50a3478e5e64a28ea310de8e5cf62c449120b89d4e205baa" => :big_sur | ||
sha256 "40c2f2d04a9d033478fdff1a272fa0d125a1dbdd746154afe97c5c36612a36af" => :catalina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not touch the bottle block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
c7aaf64
to
97f6d78
Compare
looks like flakiness, rerun a bit. |
Created by https://github.com/mislav/bump-homebrew-formula-action Update test database url
97f6d78
to
4b191b9
Compare
🤖 A scheduled task has triggered a merge. |
🙏 thanks for fixing Catalina issue |
Created by https://github.com/mislav/bump-homebrew-formula-action