Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbmate 1.11.0 #65167

Conversation

dbmate-releasebot
Copy link
Contributor

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Nov 19, 2020
@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Nov 19, 2020
@amacneil amacneil force-pushed the update-dbmate.rb-1605761899 branch from 451a3cc to 97f6d78 Compare November 19, 2020 08:52
@amacneil
Copy link
Contributor

I can't see any reason why this test is failing on 10.15:

/usr/local/Cellar/dbmate/1.11.0/bin/dbmate: cannot execute binary file

The build is very simple:

def install
  system "go", "build", "-ldflags", "-s", "-o", bin/"dbmate", "."
end

It works perfectly on 10.14 and 11.0, but fails on 10.15. Any ideas?

@jonchang
Copy link
Contributor

Yeah, this is probably the Catalina tar bug again: Homebrew/brew#6539

@amacneil amacneil force-pushed the update-dbmate.rb-1605761899 branch from 5ac7874 to c7aaf64 Compare November 19, 2020 10:13
@amacneil
Copy link
Contributor

amacneil commented Nov 19, 2020

Interesting. I added some debugging lines to CI, and apparently the binary is just "data":

==> ls -al /usr/local/Cellar/dbmate/1.11.0/bin/dbmate
-r-xr-xr-x  1 brew  staff  10600768 Nov 19 02:04 /usr/local/Cellar/dbmate/1.11.0/bin/dbmate

==> file /usr/local/Cellar/dbmate/1.11.0/bin/dbmate
/usr/local/Cellar/dbmate/1.11.0/bin/dbmate: data

==> /usr/local/Cellar/dbmate/1.11.0/bin/dbmate create
/usr/local/Cellar/dbmate/1.11.0/bin/dbmate: /usr/local/Cellar/dbmate/1.11.0/bin/dbmate: cannot execute binary file

Error: dbmate: failed

Interestingly, it works on my local Catalina machine.

It sounds like the only workaround is for a homebrew maintainer to manually remove the Catalina bottle?

@amacneil
Copy link
Contributor

I believe this is ready to merge despite the CI failure on Catalina. If there is anything I can do to resolve the failure please let me know.

Copy link
Member

@fxcoudert fxcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will reenable a work-around the Catalina bug, and we can merge once that is done

license "MIT"
head "https://github.com/amacneil/dbmate.git"

bottle do
cellar :any_skip_relocation
sha256 "1c3359021c62b14a50a3478e5e64a28ea310de8e5cf62c449120b89d4e205baa" => :big_sur
sha256 "40c2f2d04a9d033478fdff1a272fa0d125a1dbdd746154afe97c5c36612a36af" => :catalina
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not touch the bottle block

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@amacneil amacneil force-pushed the update-dbmate.rb-1605761899 branch from c7aaf64 to 97f6d78 Compare November 21, 2020 08:19
@chenrui333 chenrui333 added the 10.15 Catalina is specifically affected label Nov 22, 2020
@chenrui333
Copy link
Member

looks like flakiness, rerun a bit.

@chenrui333 chenrui333 force-pushed the update-dbmate.rb-1605761899 branch from 97f6d78 to 4b191b9 Compare November 22, 2020 21:40
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@amacneil
Copy link
Contributor

🙏 thanks for fixing Catalina issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.15 Catalina is specifically affected go Go use is a significant feature of the PR or issue test failure CI fails while running the test-do block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants