weechat 2.7

[R2robot]

As of 2.7, cmake will fail with an error for missing dependencies
instead of ignoring them. libiconv has been added as a dep and PHP has
been disabled since there are currently zero scripts available in php

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[R2robot]

Hmmm. Not sure why that test for ruby 2.6 would fail on Mojave. Is it related to when the Mojave build environment went wonky a while back?

[EricFromCanada]

 ==> brew linkage --test weechat
 ==> FAILED
 Missing libraries:
   /usr/lib/libruby.2.6.dylib

But Mojave only ships with Ruby 2.3.

[R2robot]

 ==> brew linkage --test weechat
 ==> FAILED
 Missing libraries:
   /usr/lib/libruby.2.6.dylib

But Mojave only ships with Ruby 2.3.

Well, the formula points to /usr/lib/libruby.dylib which is usually a symlink to the versioned library.

if MacOS.version >= :sierra
      args << "-DRUBY_EXECUTABLE=/usr/bin/ruby"
      args << "-DRUBY_LIB=/usr/lib/libruby.dylib"
end

Seems like it's broken in the mojave environment. This part of the formula hasn't changed in nearly 2 years.

Interestingly, the last successful weechat update was Sept 8 #44025. Then on ~Sept 21, I know that the Mojave environment took a dump and everything was failing there. It took a couple of days before builds were working on Mojave again. Reference: #44490

I don't know the details of what happened or how it was resolved, but I can only assume that something is still not quite right with the Mojave environment. A broken symlink perhaps.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[apetresc]

Is Mojave support a blocker? Could it perhaps just be dropped?

[R2robot]

Is Mojave support a blocker? Could it perhaps just be dropped?

I believe It's the Mojave build server that is the problem.. as noted above. Something about it is not right ever since it broke a while back. (as noted above).

The silly thing is, it's only the test that is failing. I didn't write the original formula and don't know the reason for testing the way it does, so I am reluctant to change anything about it as it has worked fine for the last 2 years.

I'd rather one of the brew admins take a look at the Mojave build server and see why it isn't restored back to the state it was in prior to the incident on Sept 21. But I don't know who that would be.

[EricFromCanada]

All the nodes have since been updated with the newest Xcode and tools, so rebase and push to try the build again.

[R2robot]

All the nodes have since been updated with the newest Xcode and tools, so rebase and push to try the build again.

Hmm, since when? The Mojave build failed again with the same error:

      Missing libraries:
  /usr/lib/libruby.2.6.dylib

[chenrui333]

I recently encountered the similar issue in #45467, we can probably try to remove the Ruby ref for Majove.

[R2robot]

I recently encountered the similar issue in #45467, we can probably try to remove the Ruby ref for Majove.

Thank you!

[fxcoudert]

weechat had its revision bumped in another PR, so this needs to be rebased as a single commit on top of master (no merge commit please)

[R2robot]

weechat had its revision bumped in another PR, so this needs to be rebased as a single commit on top of master (no merge commit please)

Ok, I think it's finally there.