-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nushell: restore original test #47254
Conversation
The test is still failing but I can't understand what the issue is. Any insight, @samford, @chenrui333? Here's the output that I get:
|
As mentioned in #46505 (comment), I think it's just a case that "CTRL-D" doesn't get printed out anymore, though the functionality still works. So it's just a case of removing the "CTRL-D" text from the output assertion as described in the comment. |
Formula/nushell.rb
Outdated
# Remove the test below and return to the better one above if/when Nushell | ||
# reinstates the expected behavior for Ctrl+D (EOF) | ||
assert_match version.to_s, shell_output("#{bin}/nu --version") | ||
assert_equal "#{Dir.pwd}> 2\n#{Dir.pwd}> CTRL-D\n", pipe_output("#{bin}/nu", 'echo \'{"foo":1, "bar":2}\' | from-json | get bar | echo $it') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove CTRL-D\n
from the end of the assertion text here (keeping the space before it).
Yes, I tested this locally with 0.6.0 and the previous test simply needs to be updated to remove |
Thanks guys! I made the change locally and indeed the test now pass. I've updated the PR accordingly and will now mark it as ready for review/merge. |
As discussed in #46505, the test for this formula had to be changed due to the behavior of Ctrl+D being mapped to Ctrl+C. The behavior of Ctrl+D has been restored in Nushell v0.6.0, so the test can now be restored.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?