Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diesel 1.4.3 (new formula) #46458

Closed
wants to merge 4 commits into from
Closed

Diesel 1.4.3 (new formula) #46458

wants to merge 4 commits into from

Conversation

zengxs
Copy link
Contributor

@zengxs zengxs commented Nov 7, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Command-line tool for Diesel (Rust ORM library)
https://github.com/diesel-rs/diesel

@BrewTestBot
Copy link
Member

  • Dependency 'sqlite' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.

@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Nov 7, 2019
@chenrui333
Copy link
Member

@BrewTestBot test this please

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Dec 4, 2019
@chenrui333
Copy link
Member

@zengxs Thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@chenrui333 chenrui333 closed this in b5888e6 Dec 4, 2019
@zengxs zengxs deleted the diesel branch December 5, 2019 12:59
@lock lock bot added the outdated PR was locked due to age label Jan 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 4, 2020
Comment on lines +17 to +23
system "#{bin}/diesel completions bash > diesel.bash"
system "#{bin}/diesel completions zsh > _diesel"
system "#{bin}/diesel completions fish > diesel.fish"

bash_completion.install "diesel.bash"
zsh_completion.install "_diesel"
fish_completion.install "diesel.fish"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants