Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onefetch 1.6.5 (new formula) #45878

Closed

Conversation

erikgaal
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@Moisan Moisan added the new formula PR adds a new formula to Homebrew/homebrew-core label Oct 28, 2019
@chenrui333
Copy link
Member

Relates to o2sh/onefetch#51

@erikgaal erikgaal force-pushed the patch-onefetch-new-formula branch from edfa5a6 to 7b039f2 Compare October 28, 2019 12:44
@erikgaal erikgaal requested a review from SMillerDev October 28, 2019 12:46
Copy link
Contributor

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMillerDev
Copy link
Member

You should probably use --locked on the cargo install command. To make sure it doesn't change between builds.

@erikgaal erikgaal force-pushed the patch-onefetch-new-formula branch from 7b039f2 to 12efffc Compare October 29, 2019 07:42
@erikgaal
Copy link
Contributor Author

I've added the --locked flag to the command. Is there anything else that you think needs to be changed, @SMillerDev?

@zbeekman
Copy link
Contributor

derp, I'm playing catch up with --locked. I/we/someone-else should make an audit for this. I think I saw someone is working on it, so I'll see if this goes anywhere, then submit an audit myself if it doesn't.

@SMillerDev SMillerDev added the ready to merge PR can be merged once CI is green label Oct 29, 2019
@SMillerDev
Copy link
Member

Thanks @erikgaal! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@lock lock bot added the outdated PR was locked due to age label Jan 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants