Update arduino-cli formula - version output

[gvarisco]

This commit fixes 'arduino-cli version' output by building it with the proper ldflags.

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[gvarisco]

This PR fixes CLI version output not present in #44948 due to missing ldflags. cc @Efrat19 @fxcoudert @SMillerDev

[SMillerDev]

Please don't change the bottle block.

[gvarisco]

Please don't change the bottle block.

@SMillerDev unfortunately we need to regenerate them in order to fix the 'arduino-cli version' output. Can you trigger the bot to do so?

[SMillerDev]

The bottle block is regenerated by the bot on each merge of a formula. Unless the comitter manually changes the block.

[gvarisco]

restored, sorry @SMillerDev :)

[gvarisco]

@fxcoudert @SMillerDev sorry for bothering again, but using the provided bottle as per 91e7fb6 looks like it broke the build (at least on macOS Catalina):

% brew reinstall --debug arduino-cli
/usr/local/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaLoader): loading /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/arduino-cli.rb
/usr/local/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaLoader): loading /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/go.rb
==> Reinstalling arduino-cli
/usr/bin/curl -q --globoff --show-error --user-agent Homebrew/2.1.13-54-geac74ec\ (Macintosh;\ Intel\ Mac\ OS\ X\ 10.15)\ curl/7.64.1 --location --silent --head --request GET https://homebrew.bintray.com/bottles/arduino-cli-0.5.0.catalina.bottle.1.tar.gz
==> Downloading https://homebrew.bintray.com/bottles/arduino-cli-0.5.0.catalina.bottle.1.tar.gz
==> Downloading from https://akamai.bintray.com/e6/e65612c215ea053f4b19fae9d243f5a28cbd467549eef4a3fb3f11c66b7e977a?__gda__=exp=1571006716~hmac=525a09ed4509c5623ae344753f76e220743a7bc8c072dbf1182290ba43d0
/usr/bin/curl -q --globoff --show-error --user-agent Homebrew/2.1.13-54-geac74ec\ (Macintosh;\ Intel\ Mac\ OS\ X\ 10.15)\ curl/7.64.1 --location --range 0-1 --dump-header - --write-out %{http_code} --output /dev/null https://akamai.bintray.com/e6/e65612c215ea053f4b19fae9d243f5a28cbd467549eef4a3fb3f11c66b7e977a\?__gda__=exp=1571006716\~hmac=525a09ed4509c5623ae344753f76e220743a7bc8c072dbf1182290ba43d09a42\&response-content-disposition=attachment\%3Bfilename\%3D\%22arduino-cli-0.5.0.catalina.bottle.1.tar.gz\%22\&response-content-type=application\%2Fgzip\&requestInfo=U2FsdGVkX1-SfLoIYeSYU1Wx-xre0Tle6t4N3PKGGQEShQyyp62htIUeP-L3hZWG4lTtWHa4VaOESNBzFUF72-93Rs63ErjQ_uI1y33dEX9dsapBvw1L25D9x8q3ElIZo49hdNEGQ13YE-eYqiCr0g\&response-X-Checksum-Sha1=bba0f8d43454d89cf41a2062455dcee8d2aa58f9\&response-X-Checksum-Sha2=e65612c215ea053f4b19fae9d243f5a28cbd467549eef4a3fb3f11c66b7e977a
/usr/bin/curl -q --globoff --show-error --user-agent Homebrew/2.1.13-54-geac74ec\ (Macintosh;\ Intel\ Mac\ OS\ X\ 10.15)\ curl/7.64.1 --fail --progress-bar --location --remote-time --continue-at 0 --output /Users/gvarisco/Library/Caches/Homebrew/downloads/b7861ec6828871819319ae1c02d981b0d10bc2eadf0574d6383d18c8d84b5a6f--arduino-cli-0.5.0.catalina.bottle.1.tar.gz.incomplete https://akamai.bintray.com/e6/e65612c215ea053f4b19fae9d243f5a28cbd467549eef4a3fb3f11c66b7e977a\?__gda__=exp=1571006716\~hmac=525a09ed4509c5623ae344753f76e220743a7bc8c072dbf1182290ba43d09a42\&response-content-disposition=attachment\%3Bfilename\%3D\%22arduino-cli-0.5.0.catalina.bottle.1.tar.gz\%22\&response-content-type=application\%2Fgzip\&requestInfo=U2FsdGVkX1-SfLoIYeSYU1Wx-xre0Tle6t4N3PKGGQEShQyyp62htIUeP-L3hZWG4lTtWHa4VaOESNBzFUF72-93Rs63ErjQ_uI1y33dEX9dsapBvw1L25D9x8q3ElIZo49hdNEGQ13YE-eYqiCr0g\&response-X-Checksum-Sha1=bba0f8d43454d89cf41a2062455dcee8d2aa58f9\&response-X-Checksum-Sha2=e65612c215ea053f4b19fae9d243f5a28cbd467549eef4a3fb3f11c66b7e977a
######################################################################## 100.0%
==> Pouring arduino-cli-0.5.0.catalina.bottle.1.tar.gz
tar xof /Users/gvarisco/Library/Caches/Homebrew/downloads/b7861ec6828871819319ae1c02d981b0d10bc2eadf0574d6383d18c8d84b5a6f--arduino-cli-0.5.0.catalina.bottle.1.tar.gz -C /var/folders/rp/dydbhhsx0699_7t6lmwsmd0m0000gn/T/d20191014-47269-igg8ar
cp -pR /var/folders/rp/dydbhhsx0699_7t6lmwsmd0m0000gn/T/d20191014-47269-igg8ar/arduino-cli/. /usr/local/Cellar/arduino-cli
/usr/local/Homebrew/Library/Homebrew/postinstall.rb (Formulary::FromPathLoader): loading /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/arduino-cli.rb
🍺 /usr/local/Cellar/arduino-cli/0.5.0: 5 files, 15.9MB
gvarisco@thor ~ % arduino-cli version
zsh: exec format error: arduino-cli

If I install it without using the bottle version it compiles and works as expected (go1.13.1 darwin/amd64). Is there anything we are missing here?

[fxcoudert]

This is probably Homebrew/brew#6539 which is caused by a buggy system tar in Catalina 😢