Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates llvm to the current package #31057

Closed
wants to merge 1 commit into from

Conversation

jkthorne
Copy link

No description provided.

@SMillerDev
Copy link
Member

Are you sure the newest version is supported? Because it's failing to build with it.

@DomT4
Copy link
Member

DomT4 commented Aug 13, 2018

IIRC llvm 6.0.1 support will land in the next release. It's upstream and we could consider accepting a patch I guess, but as far as I'm aware crystal-lang/crystal#6380 hasn't yet made it into a release. CC @felixbuenemann.

@jkthorne
Copy link
Author

I am building it locally and it seems to work. I dont know why but I can close this until the new crystal is released.

@jkthorne jkthorne closed this Aug 13, 2018
@jkthorne
Copy link
Author

looks like crystal just released crystal-lang/crystal#6475

@jkthorne jkthorne reopened this Aug 13, 2018
@jkthorne jkthorne closed this Aug 13, 2018
@felixbuenemann
Copy link
Contributor

Yes, Crystal 0.26.0 contains the compile fixes for LLVM 6.0, older versions require a patch.

@SMillerDev
Copy link
Member

@wontruefree will you update this PR or are you gonna make a new one for 0.26?

@DomT4
Copy link
Member

DomT4 commented Aug 14, 2018

#31086.

@lock lock bot added the outdated PR was locked due to age label Sep 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants