php: Add autoconf dependency #26298
php: Add autoconf dependency #26298
Conversation
Formula/php.rb
Outdated
| @@ -289,6 +290,8 @@ def plist; <<~EOS | |||
| system "#{sbin}/php-fpm", "-t" | |||
| system "#{bin}/phpdbg", "-V" | |||
| system "#{bin}/php-cgi", "-m" | |||
| system "#{bin}/pecl", "install", "xdebug" | |||
There was a problem hiding this comment.
The sandbox isn't going to let you write here.
There was a problem hiding this comment.
Yeah I noticed that. I thought I could get around it by using config-set extension_dir but it didn't seem to work when I tried it. Haven't looked at the pecl code but I'm guessing the settings comes from phpize/php-config.
|
I removed the test for now since it requires some more work whereas the Autoconf addition is more straightforward. |
javian
changed the title
|
And we're sure |
|
(I see libtool is already an indirect dep via unixodbc) |
|
@ilovezfs doesn't the new dependency necessitate revision bumps? |
|
No, we're doing revision bumps on #26137 so that will take care of it. |
|
According to the PHP docs |
|
They're only necessary for building from a code repository checkout. Building from a release tarball and running pecl probably shouldn't need them. |
|
@kabel right, that rings a bell now when we switched back to using php.net releases from the github ones. |
|
Thanks again @javian! |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?It was discovered that the autoconf dependency was missing as pointed out in #26170 which also made me realise we depend heavily on pecl but its not tested. I'm aware that only the php formula has the test at the moment but I'll add the others once we can confirm that this is the way forward.