Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
Inappropriately using kv merge join, in several ways. No diff table support both for kvexec and diff table indexes aren't sorted, so default merge also fails. Test suite was also being skipped.
GMS side here: [memo] merge joins must use globally sorted indexes dolthub/go-mysql-server#2803
fixes: Panic in join against diff table dolthub/dolt#8700
cespare/xxhash
withcespare/xxhash/v2
Currently, we are using two versions of the same package for xxHash:
https://github.com/dolthub/dolt/blob/d98baafd3e8248a9818e21442f4dfbdeffe78ac4/go/go.mod#L56-L57
github.com/cespare/xxhash/v2
is the latest version, which includes bug fixes and improvements. This PR updates the codebase to replacegithub.aaakk.us.kg/cespare/xxhash
withgithub.aaakk.us.kg/cespare/xxhash/v2
.No breaking changes, see https://go.dev/play/p/ZXuwERoBlEi.
Fix bugs related to table casing, loading deleted tables, and making sure we're using the appropriate branch root when updating statistics.
go-mysql-server
needed for dolphie to work; extension of
information_schema
uppercase rule doesn't apply toprocesslist
table dolthub/go-mysql-server#2764BytesBuffer
is a class that lets us avoid most allocations for spooling values to wire. Notably, the object is responsible for doubling the backing array size when appropriate, and aGrow(n int)
interface is necessary to track when this should happen. Letting the runtime do all of this would be preferable, but the runtime doubles based on slice size, and the refactors required to make that workable are more invasive. We pay for 2 mallocs on doubling, because the first one is never big enough. Not callingGrow
after allocing, or growing by too small of length compared to the allocations used will stomp previously written memory.As long as we track bytes used with the
Grow
interface this works smoothly and shaves ~30% off of tablescans.perf here: [no-release-notes] write buf reuse bump dolthub/dolt#8693
perf: cache charset bump dolthub/dolt#8691
Distinct
nodesWe weren't pruning table columns when there was a distinct clause over the projections, this resulted the deserialization of every column, even if they weren't going to make it to the result. This is bad for performance, especially if the unread columns are of
TEXT
,LONGTEXT
, 'BLOB,
LONGBLOB` type as those are stored out of band, and take longer to deserialize.fixes: Prune columns from select distinct dolthub/dolt#8689
vitess
caching_sha2_password
auth logicFor accounts without passwords, we need to account for the client sending the null byte when the server re-requests the client auth data, and then skip the
AuthMoreDataPacket
, andCachingSha2FastAuth
packets. Otherwise themysql
client errors with "Malformed packet".handleConnectionError
is used to report stats about failed connection attempts, but wasn't being called in the correct spot. The previous spot was over counting failed connection attempts, since it was called as part of the auth renegotiation flow. It has been moved to be called whenever we return an error or exit the function without a successful connection.Closed Issues