Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

himalaya 1.0.0 #200544

Merged
merged 2 commits into from
Dec 9, 2024
Merged

himalaya 1.0.0 #200544

merged 2 commits into from
Dec 9, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
The Himalaya CLI scope has changed. It does not include anymore the synchronization, nor the envelope watching. These scopes have moved to dedicated projects:

Due to the long time difference with the previous v1.0.0-beta.4 release, this changelog may be incomplete. The simplest way to upgrade is to reconfigure Himalaya CLI from scratch, using the wizard or the config.sample.toml.

Himalaya CLI will now try to adopt the conventional commits specification. Tools like git-cliff may help us generating more accurate changelogs in the future.

Added

  • Added message edit command to edit a message. To edit on place (replace a message), use --on-place.

  • Added account.list.table.preset global config option, accounts.<name>.folder.list.table.preset and accounts.<name>.envelope.list.table.preset account config options.

    These options customize the shape of tables, see examples at comfy_table::presets. Defaults to "|| |-||| ", which corresponds to comfy_table::presets::ASCII_MARKDOWN.

  • Added account.list.table.name-color config option to customize the color used for the accounts' NAME column (defaults to green).

  • Added account.list.table.backends-color config option to customize the color used for the folders' BACKENDS column (defaults to blue).

  • Added account.list.table.default-color config option to customize the color used for the folders' DEFAULT column (defaults to reset).

  • Added accounts.<name>.folder.list.table.name-color account config option to customize the color used for the folders' NAME column (defaults to blue).

  • Added accounts.<name>.folder.list.table.desc-color account config option to customize the color used for the folders' DESC column (defaults to green).

  • Added accounts.<name>.envelope.list.table.id-color account config option to customize the color used for the envelopes' ID column (defaults to red).

  • Added accounts.<name>.envelope.list.table.flags-color account config option to customize the color used for the envelopes' FLAGS column (defaults to reset).

  • Added accounts.<name>.envelope.list.table.subject-color account config option to customize the color used for the envelopes' SUBJECT column (defaults to green).

  • Added accounts.<name>.envelope.list.table.sender-color account config option to customize the color used for the envelopes' FROM column (defaults to blue).

  • Added accounts.<name>.envelope.list.table.date-color account config option to customize the color used for the envelopes' DATE column (defaults to dark_yellow).

  • Added accounts.<name>.envelope.list.table.unseen-char account config option to customize the char used for unseen envelopes (defaults to *).

  • Added accounts.<name>.envelope.list.table.replied-char account config option to customize the char used for replied envelopes (defaults to R).

  • Added accounts.<name>.envelope.list.table.flagged-char account config option to customize the char used for flagged envelopes (defaults to !).

  • Added accounts.<name>.envelope.list.table.attachment-char account config option to customize the char used for envelopes with at least one attachment (defaults to @).

Changed

  • Refactored the account configure command: this command stands now for creating or editing account configurations from the wizard. The command requires the wizard cargo feature.

  • Improved the account doctor command: it now checks the state of the config, and the new --fix argument allows you to configure keyring, OAuth 2.0 etc.

  • Improved long version --version. [#496]

  • Improved error messages when missing cargo features. For example, if a TOML configuration uses the IMAP backend without the imap cargo features, the error missing "imap" feature is displayed. #20

  • Normalized enum-based configurations, using the internally tagged representation type =. It should reduce issues due to misconfiguration, and improve othe error messages. Yet it is not perfect, see #802:

    • imap.*, maildir.* and notmuch.* moved to backend.*:

      # before
      imap.host = "localhost"
      imap.port = 143
      
      # after
      backend.type = "imap"
      backend.host = "localhost"
      backend.port = 143
    • smtp.* and sendmail.* moved to message.send.backend.*:

      # before
      smtp.host = "localhost"
      smtp.port = 25
      
      # after
      message.send.backend.type = "smtp"
      message.send.backend.host = "localhost"
      message.send.backend.port = 25
    • pgp.backend renamed pgp.type:

      # before
      pgp.backend = "commands"
      pgp.encrypt-cmd = "gpg --encrypt --quiet --armor <recipients>"
      
      # after
      pgp.type = "commands"
      pgp.encrypt-cmd = "gpg --encrypt --quiet --armor <recipients>"
    • {imap,smtp}.auth moved as well:

      # before
      imap.password.cmd = "pass show example"
      smtp.oauth2.method = "xoauth2"
      
      # after
      backend.auth.type = "password"
      backend.auth.cmd = "pass show example"
      message.send.backend.auth.type = "oauth2"
      message.send.backend.auth.method = "xoauth2"
  • Moved IMAP and SMTP encryption to encryption.type.

    This change prepares the config to accept different TLS providers with their options. The true and false variant have been removed as well:

     # before
     backend.encryption = "none" # or false
     backend.encryption = "start-tls"
     message.send.backend.encryption = "tls" # or true
    
     # after
     backend.encryption.type = "none"
     backend.encryption.type = "start-tls"
     message.send.backend.encryption.type = "tls"

Fixed

  • Fixed pre-release archives issue. [#492]
  • Fixed mailto parsing issue. [core#10]
  • Fixed Answered flag not set when replying to a message. [#508]

Removed

  • Removed systemd service from assets/ folder, as Himalaya CLI scope does not include synchronization nor watching anymore.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Dec 9, 2024
@chenrui333
Copy link
Member

    Minitest::Assertion: Expected /Error:\ cannot\ login\ to\ imap\ server/ to match "Error: \n   0: \e[91mcannot parse config file at /private/tmp/himalaya-test-20241209-12104-anc055/.config/himalaya/config.toml\e[0m\n   1: \e[91mTOML parse error at line 8, column 2\n   1:   |\n   1: 8 | [gmail]\n   1:   |  ^^^^^\n   1: unknown field `gmail`, expected one of `display-name`, `name`, `signature`, `signature-delim`, `downloads-dir`, `accounts`, `account`\n   1: \e[0m\n".
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/minitest-5.25.4/lib/minitest/assertions.rb:176:in `assert'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/minitest-5.25.4/lib/minitest/assertions.rb:291:in `assert_match'

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Dec 9, 2024
@daeho-ro daeho-ro force-pushed the bump-himalaya-1.0.0 branch from 8dfa509 to 89df5c9 Compare December 9, 2024 14:52
@daeho-ro daeho-ro force-pushed the bump-himalaya-1.0.0 branch from 89df5c9 to 3145d6d Compare December 9, 2024 14:55
@daeho-ro daeho-ro removed the test failure CI fails while running the test-do block label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 9, 2024
@BrewTestBot BrewTestBot enabled auto-merge December 9, 2024 16:06
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 9, 2024
Merged via the queue into master with commit 7df22f0 Dec 9, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-himalaya-1.0.0 branch December 9, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants