Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Use language-specific heredoc delimiters #199000

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Nov 26, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • I looked for singular EOS heredoc occurrences per-language that I could fix, and settled on HTML, Zig, diff and TSV.
  • We’re regressing a bit on some of them in general (like CPP), so we’ll have to think of a strategy for that (some kind of lint that ignores caveats but nudges the others towards changing?). I’ll write an issue for the rest of the work, because it feels like I’m chasing a goal that will never be attainable of getting rid of all the EOS.

@issyl0 issyl0 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Nov 26, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit 3bea6cf Nov 26, 2024
17 checks passed
@chenrui333 chenrui333 deleted the random-singular-heredocs branch November 26, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants