television 0.5.3 (new formula) #198998
Merged
television 0.5.3 (new formula) #198998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automerge-skip
p-linnane
force-pushed
the
television-add-formula
branch
from
679e2b1 to
a1ed75e
Compare
chenrui333
added
the
CI-no-fail-fast
chenrui333
force-pushed
the
television-add-formula
branch
2 times, most recently
from
d52507f to
b36a6a3
Compare
SMillerDev
reviewed
Nov 26, 2024
p-linnane
force-pushed
the
television-add-formula
branch
from
d78cfd5 to
abc4361
Compare
|
The TUI output is not consistent in testing. Would need to drop that part of the test and just do a version check to ship this. Thoughts @chenrui333 @SMillerDev? |
|
I tested, it seems working fine in my local, weird that it does not work in CI |
chenrui333
force-pushed
the
television-add-formula
branch
3 times, most recently
from
035b3de to
ce4ad1a
Compare
Signed-off-by: Patrick Linnane <[email protected]> television: update test Signed-off-by: Rui Chen <[email protected]>
chenrui333
force-pushed
the
television-add-formula
branch
from
ce4ad1a to
0421c81
Compare
chenrui333
approved these changes
Nov 28, 2024
daeho-ro
approved these changes
Nov 28, 2024
|
Thank you @chenrui333! |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?